From: Joerg Roedel <joro@8bytes.org>
To: Shuah Khan <shuah.kh@samsung.com>
Cc: akpm@linux-foundation.org, alexander.h.duyck@intel.com,
linux-kernel@vger.kernel.org, shuahkhan@gmail.com
Subject: Re: [PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors
Date: Tue, 7 Jan 2014 15:26:25 +0100 [thread overview]
Message-ID: <20140107142625.GC2742@8bytes.org> (raw)
In-Reply-To: <52C700BC.1010200@samsung.com>
On Fri, Jan 03, 2014 at 11:26:04AM -0700, Shuah Khan wrote:
> On 12/30/2013 07:15 AM, Joerg Roedel wrote:
> >I think it is better to check for this in a seperate function and use
> >err_printk instead of dev_warn in the end to print the errors.
> >The new function can then be called in the dma_debug_device_change
> >callback like device_dma_allocations is.
> >
>
> I did explore separate function option and backed off from it since
> the new routine will have to duplicate what device_dma_allocations()
> does except that it checks for entry->map_err_type.
>
> I still have the patch that does that saved away. If you still
> prefer that approach, I can rework the patch and send it.
You can get rid of the code duplication by defining for_each macros for
the list traversals. So I would still prefer to have this check in a
seperate function.
Joerg
next prev parent reply other threads:[~2014-01-07 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 20:56 [PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors Shuah Khan
2013-12-30 14:15 ` Joerg Roedel
2014-01-03 18:26 ` Shuah Khan
2014-01-07 14:26 ` Joerg Roedel [this message]
2014-01-07 15:00 ` Shuah Khan
2014-01-07 15:12 ` Joerg Roedel
2014-01-07 17:22 ` Shuah Khan
2014-01-11 0:25 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107142625.GC2742@8bytes.org \
--to=joro@8bytes.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.