From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: xend vs xl with pci=['' are not owned by pciback or pcistub will still launch. Date: Tue, 7 Jan 2014 09:29:13 -0500 Message-ID: <20140107142913.GD3588@phenom.dumpdata.com> References: <20140106175713.GB28636@phenom.dumpdata.com> <1389093778.31766.131.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1W0Xek-0005y2-2P for xen-devel@lists.xenproject.org; Tue, 07 Jan 2014 14:29:22 +0000 Content-Disposition: inline In-Reply-To: <1389093778.31766.131.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Tue, Jan 07, 2014 at 11:22:58AM +0000, Ian Campbell wrote: > create ^ > thanks > > On Mon, 2014-01-06 at 12:57 -0500, Konrad Rzeszutek Wilk wrote: > > In Xend, if I had a pci entry in the guest config and the > > PCI device was not assigned to xen-pciback or pci-stub it > > would refuse to launch the guest. > > > > Not so with 'xl'. It will complain but still launch: > > It looks like domcreate_attach_pci() is ignoring the result of > libxl__device_pci_add(). It appears to have always done so. > > I suppose there is an argument that there are usecases where starting > the domain at all even without the full set of devices is better than > not starting it at all, but I think I agree that the default should be > to fail if some devices are not available. The guest wasn't too happy about some of them missing :-) > > Is this a blocker for you for 4.4 or can it wait for 4.5? Not a blocker. It can wait, just want to make sure we don't forget.