From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Increase i_writecount during gfs2_setattr_chown
Date: Tue, 7 Jan 2014 07:52:15 -0800 [thread overview]
Message-ID: <20140107155215.GA21723@infradead.org> (raw)
In-Reply-To: <892095916.49469226.1389046561115.JavaMail.root@redhat.com>
On Mon, Jan 06, 2014 at 05:16:01PM -0500, Bob Peterson wrote:
> Hi,
>
> This patch calls get_write_access in function gfs2_setattr_chown,
> which merely increases inode->i_writecount for the duration of the
> function. That will ensure that any file closes won't delete the
> inode's multi-block reservation while the function is running.
> It also ensures that a multi-block reservation exists when needed
> for quota change operations during the chown.
Can you explain how gfs2 (ab-)uses i_writecount in the allocator?
i_writecunt has very complicated semantics including negative values
to deal with mappings for executables, and I can't really see how these
high-level semantics interact well with a block allocator.
next prev parent reply other threads:[~2014-01-07 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1027021866.49462200.1389046460522.JavaMail.root@redhat.com>
2014-01-06 22:16 ` [Cluster-devel] [GFS2 PATCH] GFS2: Increase i_writecount during gfs2_setattr_chown Bob Peterson
2014-01-07 13:15 ` Steven Whitehouse
2014-01-07 15:52 ` Christoph Hellwig [this message]
2014-01-07 17:38 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107155215.GA21723@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.