Re: [PATCH] kernel: use oldnoconfig instead of yes '' | make oldconfig

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]

On Tue, Jan 07, 2014 at 04:20:37PM +0100, Alexandre Belloni wrote:
> On 07/01/2014 15:35, Martin Jansa wrote:
> > On Tue, Jan 07, 2014 at 03:18:37PM +0100, Alexandre Belloni wrote:
> >> When using a defconfig, using yes '' | make oldconfig may not result in
> >> the correct configuration being set. For example:
> > 
> >>  $ grep USB_ETH .config
> >>  CONFIG_USB_ETH=y
> >>  CONFIG_USB_ETH_RNDIS=y
> >>  CONFIG_USB_ETH_EEM=y
> >>  $ make savedefconfig
> >>  scripts/kconfig/conf --savedefconfig=defconfig Kconfig
> >>  $ cp defconfig .config
> >>  ‘defconfig’ -> ‘.config’
> >>  $ yes '' | make oldconfig
> >>  [...]
> >>  #
> >>  # configuration written to .config
> >>  #
> >>  $ grep USB_ETH .config
> >>  CONFIG_USB_ETH=m
> >>  CONFIG_USB_ETH_RNDIS=y
> >>  CONFIG_USB_ETH_EEM=y
> >>
> >> Using make olddefconfig solves that but we'll use oldnoconfig for
> >> backward compatibility with older kernels.
> > 
> > Looks good, I have few kernel recipes where I had to fixup resulting
> > .config after "make savedefconfig", "yes '' | make oldconfig" combo
> > exactly because of some =y changing to -m.
> > 
> > 1) Do you know since when oldnoconfig is supported?
> > 
> > IIRC oldest kernel I've in BSPs is 2.6.24. 
> 
> oldnoconfig seems to be present since 2.6.36. olddefconfig is an alias
> that appeared with fb16d8912db5268f29706010ecafff74b971c58d which is
> present since v3.7.
> 
> Then hat about using:
> 
> oe_runmake oldnoconfig || yes '' | oe_runmake oldconfig

Looks safer (assuming that oldnoconfig will return error only in cases
where oldnoconfig target doesn't exist in Makefile, otherwise fall-back
to yes '' could be a bit confusing).

In worst case you can add KERNEL_VERSION check or show bb.warn when
oldnoconfig isn't supported.

> > 2) Could you send similar patch for
> > meta-openembedded/meta-oe/recipes-kernel/linux/linux.inc
> > ?
> > 
> 
> Sure, will do once we agreed on this patch

Thanks

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]