Re: [PATCH] ALSA: compress: add num_sample_rates in snd_codec_desc

[Vinod Koul <vinod.koul@intel.com>]

On Tue, Jan 07, 2014 at 05:35:10PM +0000, Mark Brown wrote:
> On Tue, Jan 07, 2014 at 09:55:42PM +0530, Vinod Koul wrote:
> 
> >  struct snd_codec_desc {
> >  	__u32 max_ch;
> >  	__u32 sample_rates[MAX_NUM_SAMPLE_RATES];
> > +	__u32 num_sample_rates;
> >  	__u32 bit_rate[MAX_NUM_BITRATES];
> >  	__u32 num_bitrates;
> >  	__u32 rate_control;
> 
> This is adding a field to the userspace ABI which will break it...  not
> sure if we care or not but it probably ought to be noted in the commit
> log at the very least; people do build things like distros with headers
> from older kernels than the ones they run.
I am not aware is any users of desciptors yet :) so thats why went ahead and
modifed... This is long term plan to query dynamic capablities of device using
this

--
~Vinod