From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ALSA: compress: add num_sample_rates in snd_codec_desc
Date: Tue, 7 Jan 2014 17:35:10 +0000 [thread overview]
Message-ID: <20140107173510.GD31886@sirena.org.uk> (raw)
In-Reply-To: <1389111942-20810-1-git-send-email-vinod.koul@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 539 bytes --]
On Tue, Jan 07, 2014 at 09:55:42PM +0530, Vinod Koul wrote:
> struct snd_codec_desc {
> __u32 max_ch;
> __u32 sample_rates[MAX_NUM_SAMPLE_RATES];
> + __u32 num_sample_rates;
> __u32 bit_rate[MAX_NUM_BITRATES];
> __u32 num_bitrates;
> __u32 rate_control;
This is adding a field to the userspace ABI which will break it... not
sure if we care or not but it probably ought to be noted in the commit
log at the very least; people do build things like distros with headers
from older kernels than the ones they run.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-01-07 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 16:25 [PATCH] ALSA: compress: add num_sample_rates in snd_codec_desc Vinod Koul
2014-01-07 17:34 ` Takashi Iwai
2014-01-07 16:39 ` Vinod Koul
2014-01-07 17:35 ` Mark Brown [this message]
2014-01-07 16:38 ` Vinod Koul
2014-01-07 17:43 ` Mark Brown
2014-01-07 17:46 ` Takashi Iwai
2014-01-07 17:41 ` Takashi Iwai
2014-01-07 17:47 ` Mark Brown
2014-01-08 4:16 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107173510.GD31886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.