From: Dan Carpenter <dan.carpenter@oracle.com>
To: a.hajda@samsung.com
Cc: linux-media@vger.kernel.org
Subject: re: [media] Add driver for Samsung S5K5BAF camera sensor
Date: Wed, 8 Jan 2014 12:09:42 +0300 [thread overview]
Message-ID: <20140108090942.GA28296@elgon.mountain> (raw)
Hello Andrzej Hajda,
This is a semi-automatic email about new static checker warnings.
The patch 7d459937dc09: "[media] Add driver for Samsung S5K5BAF
camera sensor" from Dec 5, 2013, leads to the following Smatch
complaint:
drivers/media/i2c/s5k5baf.c:554 s5k5baf_fw_get_seq()
warn: variable dereferenced before check 'fw' (see line 551)
drivers/media/i2c/s5k5baf.c
550 struct s5k5baf_fw *fw = state->fw;
551 u16 *data = fw->data + 2 * fw->count;
^^^^^^^^^
Dereference.
552 int i;
553
554 if (fw == NULL)
^^^^^^^^^^
Check.
555 return NULL;
556
regards,
dan carpenter
next reply other threads:[~2014-01-08 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 9:09 Dan Carpenter [this message]
2014-01-08 10:29 ` [media] Add driver for Samsung S5K5BAF camera sensor Sachin Kamat
-- strict thread matches above, loose matches on Subject: below --
2014-01-08 9:58 Dan Carpenter
2014-01-08 11:58 ` Andrzej Hajda
2014-01-08 12:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108090942.GA28296@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=a.hajda@samsung.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.