From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v4 1/3] ARM: mvebu: Add support to get the ID and the revision of a SoC Date: Wed, 8 Jan 2014 13:55:37 +0100 Message-ID: <201401081355.38293.arnd@arndb.de> References: <1389112504-9931-1-git-send-email-gregory.clement@free-electrons.com> <1389112504-9931-2-git-send-email-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389112504-9931-2-git-send-email-gregory.clement@free-electrons.com> Sender: stable-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Gregory CLEMENT , Wolfram Sang , linux-i2c@vger.kernel.org, Jason Cooper , Andrew Lunn , Thomas Petazzoni , stable@vger.kernel.org, Ezequiel Garcia , Sebastian Hesselbarth List-Id: linux-i2c@vger.kernel.org On Tuesday 07 January 2014, Gregory CLEMENT wrote: > diff --git a/include/linux/mvebu-soc-id.h b/include/linux/mvebu-soc-id.h > new file mode 100644 > index 000000000000..31654252fe35 > --- /dev/null > +++ b/include/linux/mvebu-soc-id.h > +#ifdef CONFIG_ARCH_MVEBU > +int mvebu_get_soc_id(u32 *dev, u32 *rev); > +#else > +static inline int mvebu_get_soc_id(u32 *dev, u32 *rev) > +{ > + return -1; > +} > +#endif > + > +#endif /* __LINUX_MVEBU_SOC_ID_H */ With the quirk handling in patch 3, I think we should remove the public interface and EXPORT_SYMBOL(), as well as move this header file into mach-mvebu. That said, we may want to add support for the soc_bus later on (not as part of the stable bug fix) to make it possible to query the soc version from user space through the standard sysfs files. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 8 Jan 2014 13:55:37 +0100 Subject: [PATCH v4 1/3] ARM: mvebu: Add support to get the ID and the revision of a SoC In-Reply-To: <1389112504-9931-2-git-send-email-gregory.clement@free-electrons.com> References: <1389112504-9931-1-git-send-email-gregory.clement@free-electrons.com> <1389112504-9931-2-git-send-email-gregory.clement@free-electrons.com> Message-ID: <201401081355.38293.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 07 January 2014, Gregory CLEMENT wrote: > diff --git a/include/linux/mvebu-soc-id.h b/include/linux/mvebu-soc-id.h > new file mode 100644 > index 000000000000..31654252fe35 > --- /dev/null > +++ b/include/linux/mvebu-soc-id.h > +#ifdef CONFIG_ARCH_MVEBU > +int mvebu_get_soc_id(u32 *dev, u32 *rev); > +#else > +static inline int mvebu_get_soc_id(u32 *dev, u32 *rev) > +{ > + return -1; > +} > +#endif > + > +#endif /* __LINUX_MVEBU_SOC_ID_H */ With the quirk handling in patch 3, I think we should remove the public interface and EXPORT_SYMBOL(), as well as move this header file into mach-mvebu. That said, we may want to add support for the soc_bus later on (not as part of the stable bug fix) to make it possible to query the soc version from user space through the standard sysfs files. Arnd