From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 3/6] ARM: tegra: Add efuse bindings Date: Wed, 8 Jan 2014 21:09:48 +0100 Message-ID: <20140108200946.GE1298@ulmo.nvidia.com> References: <1387891931-9854-1-git-send-email-pdeschrijver@nvidia.com> <1387891931-9854-4-git-send-email-pdeschrijver@nvidia.com> <52CB14D3.2060904@wwwdotorg.org> <20140108133951.GD1592@ulmo.nvidia.com> <52CD9DFB.9010007@wwwdotorg.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dFWYt1i2NyOo1oI9" Return-path: Content-Disposition: inline In-Reply-To: <52CD9DFB.9010007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Peter De Schrijver , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org --dFWYt1i2NyOo1oI9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: > On 01/08/2014 06:39 AM, Thierry Reding wrote: > > On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: > >> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > > [...] > >>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra= 20.dtsi > >> > >>> + efuse@7000F800 { > >> > >> "fuse" might be a better node name; "efuse" is presumably the name of > >> the instance, not the type of object. > >=20 > > There's another occurrence I noticed recently where we haven't followed > > that rule. The PMIC node on Venice2 for instance is called as3722. > > Perhaps that should also be renamed. >=20 > Yes, we should fix that. Care to send a patch? Ugh... I've just been going through some of the other DTS files and see that quite a lot of other places aren't following this rule either. The Beaver DTS has things like: rt5640: rt5640@1c { ... }; which I guess "should have been" rt5640: codec@1c { /* or even audio-codec@1c */ ... }; and pmic: tps65911@2d { ... }; > which would be another candidate for pmic@2d. Perhaps it isn't worth fixing them all up after all? Thierry --dFWYt1i2NyOo1oI9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSzbCKAAoJEN0jrNd/PrOhK6EP/RYFt4xDK/5hdp4EPLPOJtNf Ecw5kpV/DClLaYh72xvzOplIE47gEedCHJyzv0CG6+bf/JEaTJ9uDj2Kq0UIYxqt gJTlzHZ3qzOOME80XP0hRSmzznGKqLxgGXGKmvHaKgvM0VSyjXm1lGqz1wzgVDjA 5b+lAVXJPaXW5pV2uCDacBxXHtpWb3b98tBman6khjI77zuDUPpXcdCzqMKqGxoz sMT+nA179raHHy06xNR70OsvzPsZqkkPC1fnsdmonLTHrkYsfjjR8BYqehP30fiX fE16Ty6Fqxn3HsWd1msE4nyUzXhxB2rJUVKExKavXpYzjAaocLooUGXnad8ptUeu 3BkCHqaDmfqB0aN3gFb/odJZXpN9mAnrEjLft6FBKOP3SQkPLoLllKdRfEHTDzJ/ grES4xodoZE0wHw3uqe+2WQfQ6klRRdl8+WYOnw6CWQc9CICXX11AXl32bYGH+dB xE4oRuSZWTBv6nwO7u93o6Mow8XHy7G225z+WB0UeFWfZ7Nc6cvKD7OICI/HhZVD OQLq1hRnostBrPzfzlRpG4WokB2yJdDlCyNxuqR/xwQH2qz5+IanFWecJYeGqRRU 1S2bsMTlmIj0ODArNA8+roImmGvghAOLkdyLPGjuXTpZ7h7G6KS2S9CQt7Fj32z7 8iZERIaCEwWmyvOR91nn =qana -----END PGP SIGNATURE----- --dFWYt1i2NyOo1oI9-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Wed, 8 Jan 2014 21:09:48 +0100 Subject: [PATCH v2 3/6] ARM: tegra: Add efuse bindings In-Reply-To: <52CD9DFB.9010007@wwwdotorg.org> References: <1387891931-9854-1-git-send-email-pdeschrijver@nvidia.com> <1387891931-9854-4-git-send-email-pdeschrijver@nvidia.com> <52CB14D3.2060904@wwwdotorg.org> <20140108133951.GD1592@ulmo.nvidia.com> <52CD9DFB.9010007@wwwdotorg.org> Message-ID: <20140108200946.GE1298@ulmo.nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: > On 01/08/2014 06:39 AM, Thierry Reding wrote: > > On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: > >> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > > [...] > >>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > >> > >>> + efuse at 7000F800 { > >> > >> "fuse" might be a better node name; "efuse" is presumably the name of > >> the instance, not the type of object. > > > > There's another occurrence I noticed recently where we haven't followed > > that rule. The PMIC node on Venice2 for instance is called as3722. > > Perhaps that should also be renamed. > > Yes, we should fix that. Care to send a patch? Ugh... I've just been going through some of the other DTS files and see that quite a lot of other places aren't following this rule either. The Beaver DTS has things like: rt5640: rt5640 at 1c { ... }; which I guess "should have been" rt5640: codec at 1c { /* or even audio-codec at 1c */ ... }; and pmic: tps65911 at 2d { ... }; > which would be another candidate for pmic at 2d. Perhaps it isn't worth fixing them all up after all? Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757321AbaAHUMA (ORCPT ); Wed, 8 Jan 2014 15:12:00 -0500 Received: from mail-bk0-f54.google.com ([209.85.214.54]:55628 "EHLO mail-bk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757277AbaAHUL6 (ORCPT ); Wed, 8 Jan 2014 15:11:58 -0500 Date: Wed, 8 Jan 2014 21:09:48 +0100 From: Thierry Reding To: Stephen Warren Cc: Peter De Schrijver , linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/6] ARM: tegra: Add efuse bindings Message-ID: <20140108200946.GE1298@ulmo.nvidia.com> References: <1387891931-9854-1-git-send-email-pdeschrijver@nvidia.com> <1387891931-9854-4-git-send-email-pdeschrijver@nvidia.com> <52CB14D3.2060904@wwwdotorg.org> <20140108133951.GD1592@ulmo.nvidia.com> <52CD9DFB.9010007@wwwdotorg.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dFWYt1i2NyOo1oI9" Content-Disposition: inline In-Reply-To: <52CD9DFB.9010007@wwwdotorg.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dFWYt1i2NyOo1oI9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: > On 01/08/2014 06:39 AM, Thierry Reding wrote: > > On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: > >> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > > [...] > >>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra= 20.dtsi > >> > >>> + efuse@7000F800 { > >> > >> "fuse" might be a better node name; "efuse" is presumably the name of > >> the instance, not the type of object. > >=20 > > There's another occurrence I noticed recently where we haven't followed > > that rule. The PMIC node on Venice2 for instance is called as3722. > > Perhaps that should also be renamed. >=20 > Yes, we should fix that. Care to send a patch? Ugh... I've just been going through some of the other DTS files and see that quite a lot of other places aren't following this rule either. The Beaver DTS has things like: rt5640: rt5640@1c { ... }; which I guess "should have been" rt5640: codec@1c { /* or even audio-codec@1c */ ... }; and pmic: tps65911@2d { ... }; > which would be another candidate for pmic@2d. Perhaps it isn't worth fixing them all up after all? Thierry --dFWYt1i2NyOo1oI9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSzbCKAAoJEN0jrNd/PrOhK6EP/RYFt4xDK/5hdp4EPLPOJtNf Ecw5kpV/DClLaYh72xvzOplIE47gEedCHJyzv0CG6+bf/JEaTJ9uDj2Kq0UIYxqt gJTlzHZ3qzOOME80XP0hRSmzznGKqLxgGXGKmvHaKgvM0VSyjXm1lGqz1wzgVDjA 5b+lAVXJPaXW5pV2uCDacBxXHtpWb3b98tBman6khjI77zuDUPpXcdCzqMKqGxoz sMT+nA179raHHy06xNR70OsvzPsZqkkPC1fnsdmonLTHrkYsfjjR8BYqehP30fiX fE16Ty6Fqxn3HsWd1msE4nyUzXhxB2rJUVKExKavXpYzjAaocLooUGXnad8ptUeu 3BkCHqaDmfqB0aN3gFb/odJZXpN9mAnrEjLft6FBKOP3SQkPLoLllKdRfEHTDzJ/ grES4xodoZE0wHw3uqe+2WQfQ6klRRdl8+WYOnw6CWQc9CICXX11AXl32bYGH+dB xE4oRuSZWTBv6nwO7u93o6Mow8XHy7G225z+WB0UeFWfZ7Nc6cvKD7OICI/HhZVD OQLq1hRnostBrPzfzlRpG4WokB2yJdDlCyNxuqR/xwQH2qz5+IanFWecJYeGqRRU 1S2bsMTlmIj0ODArNA8+roImmGvghAOLkdyLPGjuXTpZ7h7G6KS2S9CQt7Fj32z7 8iZERIaCEwWmyvOR91nn =qana -----END PGP SIGNATURE----- --dFWYt1i2NyOo1oI9--