All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Frank Schäfer" <fschaefer.oss@googlemail.com>
Cc: Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: sysfs warnings since kernel 3.13-rc1:  "WARNING: ... at fs/sysfs/group.c:214 sysfs_remove_group"
Date: Wed, 8 Jan 2014 12:23:05 -0800	[thread overview]
Message-ID: <20140108202305.GA8417@kroah.com> (raw)
In-Reply-To: <52CDAEA2.2000801@googlemail.com>

On Wed, Jan 08, 2014 at 09:01:38PM +0100, Frank Schäfer wrote:
> Am 07.01.2014 18:59, schrieb Tejun Heo:
> > Hello,
> >
> > cc'ing Mauro and quoting whole body for him.
> >
> > So, ummm, the sysfs rule was that any group below a device should be
> > removed before the device itself is removed; however, nothing really
> > checked whether this actually was the case.  We didn't care whether
> > the order was reversed and if somebody forgot to remove the group
> > afterwards, we just leaked it.  After this commit, sysfs now whines if
> > the order is reversed, so the warning.
> >
> > While this should probably be fixed from the v4l side, I'm really
> > skeptical we're gaining anything by requiring users to explicitly
> > remove groups during device removal.  In most cases, this is a
> > completely unnecessary task.  Maybe we should just hunt down all
> > remove_group calls and remove all the unnecessary ones.
> >
> > Thanks.
> What about the USB mass storage devices ?
> Is it just a coincidence that this happens with two completely different
> types of USB devices ?

Yes it is, there's a big long thread on the linux-usb and scsi mailing
lists about this, and the fix should be final soon.

thanks,

greg k-h

  reply	other threads:[~2014-01-08 20:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 17:44 sysfs warnings since kernel 3.13-rc1: "WARNING: ... at fs/sysfs/group.c:214 sysfs_remove_group" Frank Schäfer
2014-01-07 17:59 ` Tejun Heo
2014-01-08 20:01   ` Frank Schäfer
2014-01-08 20:23     ` Greg Kroah-Hartman [this message]
2014-01-08 20:32     ` Mauro Carvalho Chehab
2014-01-11 19:42       ` Frank Schäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140108202305.GA8417@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fschaefer.oss@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.