From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by ozlabs.org (Postfix) with ESMTP id 09C9A2C0084 for ; Thu, 9 Jan 2014 07:25:44 +1100 (EST) Date: Wed, 8 Jan 2014 12:26:13 -0800 From: Greg Kroah-Hartman To: Sudeep Holla Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs Message-ID: <20140108202613.GD8417@kroah.com> References: <1389209168-17189-1-git-send-email-sudeep.holla@arm.com> <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> Cc: devicetree@vger.kernel.org, Ashok Raj , Rob Herring , x86@kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: > From: Sudeep Holla > > This patch adds initial support for providing processor cache information > to userspace through sysfs interface. This is based on x86 implementation > and hence the interface is intended to be fully compatible. > > A per-cpu array of cache information maintained is used mainly for > sysfs-related book keeping. > > Signed-off-by: Sudeep Holla > --- > drivers/base/Makefile | 2 +- > drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/cacheinfo.h | 43 +++++++ > 3 files changed, 340 insertions(+), 1 deletion(-) > create mode 100644 drivers/base/cacheinfo.c > create mode 100644 include/linux/cacheinfo.h You are creating sysfs files, yet you didn't add Documentation/ABI/ information, which is required. Please fix that. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Wed, 8 Jan 2014 12:26:13 -0800 Subject: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs In-Reply-To: <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> References: <1389209168-17189-1-git-send-email-sudeep.holla@arm.com> <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> Message-ID: <20140108202613.GD8417@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: > From: Sudeep Holla > > This patch adds initial support for providing processor cache information > to userspace through sysfs interface. This is based on x86 implementation > and hence the interface is intended to be fully compatible. > > A per-cpu array of cache information maintained is used mainly for > sysfs-related book keeping. > > Signed-off-by: Sudeep Holla > --- > drivers/base/Makefile | 2 +- > drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/cacheinfo.h | 43 +++++++ > 3 files changed, 340 insertions(+), 1 deletion(-) > create mode 100644 drivers/base/cacheinfo.c > create mode 100644 include/linux/cacheinfo.h You are creating sysfs files, yet you didn't add Documentation/ABI/ information, which is required. Please fix that. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs Date: Wed, 8 Jan 2014 12:26:13 -0800 Message-ID: <20140108202613.GD8417@kroah.com> References: <1389209168-17189-1-git-send-email-sudeep.holla@arm.com> <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1389209168-17189-2-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sudeep Holla Cc: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Ashok Raj , Benjamin Herrenschmidt , Rob Herring List-Id: devicetree@vger.kernel.org On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: > From: Sudeep Holla > > This patch adds initial support for providing processor cache information > to userspace through sysfs interface. This is based on x86 implementation > and hence the interface is intended to be fully compatible. > > A per-cpu array of cache information maintained is used mainly for > sysfs-related book keeping. > > Signed-off-by: Sudeep Holla > --- > drivers/base/Makefile | 2 +- > drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/cacheinfo.h | 43 +++++++ > 3 files changed, 340 insertions(+), 1 deletion(-) > create mode 100644 drivers/base/cacheinfo.c > create mode 100644 include/linux/cacheinfo.h You are creating sysfs files, yet you didn't add Documentation/ABI/ information, which is required. Please fix that. greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757357AbaAHUZq (ORCPT ); Wed, 8 Jan 2014 15:25:46 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42001 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbaAHUZn (ORCPT ); Wed, 8 Jan 2014 15:25:43 -0500 Date: Wed, 8 Jan 2014 12:26:13 -0800 From: Greg Kroah-Hartman To: Sudeep Holla Cc: x86@kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ashok Raj , Benjamin Herrenschmidt , Rob Herring Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs Message-ID: <20140108202613.GD8417@kroah.com> References: <1389209168-17189-1-git-send-email-sudeep.holla@arm.com> <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: > From: Sudeep Holla > > This patch adds initial support for providing processor cache information > to userspace through sysfs interface. This is based on x86 implementation > and hence the interface is intended to be fully compatible. > > A per-cpu array of cache information maintained is used mainly for > sysfs-related book keeping. > > Signed-off-by: Sudeep Holla > --- > drivers/base/Makefile | 2 +- > drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/cacheinfo.h | 43 +++++++ > 3 files changed, 340 insertions(+), 1 deletion(-) > create mode 100644 drivers/base/cacheinfo.c > create mode 100644 include/linux/cacheinfo.h You are creating sysfs files, yet you didn't add Documentation/ABI/ information, which is required. Please fix that. greg k-h