All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Zhihui Zhang <zzhsuny@gmail.com>
Cc: gleb@redhat.com, pbonzini@redhat.com, hpa@zytor.com, kvm@vger.kernel.org
Subject: Re: [PATCH] Move translate_gpa() initialization for the nested context into init_kvm_nested_mmu()
Date: Wed, 8 Jan 2014 19:09:08 -0200	[thread overview]
Message-ID: <20140108210908.GC20624@amt.cnet> (raw)
In-Reply-To: <1388452941-32178-1-git-send-email-zzhsuny@gmail.com>

On Mon, Dec 30, 2013 at 08:22:21PM -0500, Zhihui Zhang wrote:
> This is the right place to set the function pointer. In addition, change function name
> from translate_nested_gpa() to translate_gpa_nested() to match the naming convention of
> other functions (e.g., paging64_gva_to_gpa_nested()).
> 
> Signed-off-by: Zhihui Zhang <zzhsuny@gmail.com>

Why is it the right place? The assignment was executed once per
VM-creation, now its executed once per kvm_mmu_reset_context
(which is a downside). Another downside is that 

  	vcpu->arch.mmu.translate_gpa = translate_gpa;
	vcpu->arch.nested_mmu.translate_gpa = translate_nested_gpa;

You lose this proximity.


      reply	other threads:[~2014-01-08 21:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-31  1:22 [PATCH] Move translate_gpa() initialization for the nested context into init_kvm_nested_mmu() Zhihui Zhang
2014-01-08 21:09 ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140108210908.GC20624@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=gleb@redhat.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=zzhsuny@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.