From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Anthony Olech <anthony.olech.opensource@diasemi.com>
Subject: Re: [PATCH] ASoC: da9055: Partially fix device registration
Date: Wed, 8 Jan 2014 21:26:17 +0000 [thread overview]
Message-ID: <20140108212617.GA18611@lee--X1> (raw)
In-Reply-To: <1389213535-10801-1-git-send-email-broonie@kernel.org>
> index 956afa445998..e293797ded66 100644
> --- a/include/linux/mfd/da9055/core.h
> +++ b/include/linux/mfd/da9055/core.h
> @@ -42,7 +42,7 @@ struct da9055 {
> struct regmap *regmap;
> struct regmap_irq_chip_data *irq_data;
> struct device *dev;
> - struct i2c_client *i2c_client;
> + struct i2c_client *i2c_client, *codec;
I'd prefer this on its own in a struct declaration.
Apart from that MFD parts look good to me.
Can you create an IB for me to pull from?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2014-01-08 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 20:38 [PATCH] ASoC: da9055: Partially fix device registration Mark Brown
2014-01-08 21:26 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108212617.GA18611@lee--X1 \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=anthony.olech.opensource@diasemi.com \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.