All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Alexander Usyskin <alexander.usyskin@intel.com>
Subject: Re: [char-misc 1/4] mei: do not run reset flow from the interrupt thread
Date: Wed, 8 Jan 2014 15:24:10 -0800	[thread overview]
Message-ID: <20140108232410.GA11300@kroah.com> (raw)
In-Reply-To: <1389205164-13553-2-git-send-email-tomas.winkler@intel.com>

On Wed, Jan 08, 2014 at 08:19:21PM +0200, Tomas Winkler wrote:
> This fixes a potential deadlock in case of a firmware
> initiated reset
> 
> mei_reset has a dialog with the interrupt thread hence
> it has to be run from an another work item
> 
> Most of the mei_resets were called from mei_hbm_dispatch
> which is called in interrupt thread context so this
> function underwent major revamp. The error code is
> propagated to the interrupt thread and if needed
> the reset is scheduled from there.
> 
> Cc: <stable@vger.kernel.org> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> ---
>  drivers/misc/mei/hbm.c       | 200 +++++++++++++++++++++++++++----------------
>  drivers/misc/mei/hbm.h       |   6 +-
>  drivers/misc/mei/hw-me.c     |  32 ++++---
>  drivers/misc/mei/init.c      | 100 +++++++++++++---------
>  drivers/misc/mei/interrupt.c |   9 +-
>  drivers/misc/mei/mei_dev.h   |   1 +
>  6 files changed, 210 insertions(+), 138 deletions(-)

This is a _really_ big patch for a stable kernel tree.  Are you sure
it's needed there?  Please go read Documentation/stable_kernel_rules.txt
again.

greg k-h

  reply	other threads:[~2014-01-08 23:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 18:19 [char-misc 0/4] mei: reset fix Tomas Winkler
2014-01-08 18:19 ` [char-misc 1/4] mei: do not run reset flow from the interrupt thread Tomas Winkler
2014-01-08 23:24   ` Greg KH [this message]
2014-01-11 22:46     ` Winkler, Tomas
2014-01-11 23:38       ` Greg KH
2014-01-12  9:00         ` Winkler, Tomas
2014-01-08 18:19 ` [char-misc 2/4] mei: use hbm idle state to prevent spurious resets Tomas Winkler
2014-01-08 18:19 ` [char-misc 3/4] mei: revamp mei reset state machine Tomas Winkler
2014-01-08 23:24   ` Greg KH
2014-01-08 23:26   ` Greg KH
2014-01-11 16:25     ` Winkler, Tomas
2014-01-08 18:19 ` [char-misc 4/4] mei: limit the number of consecutive resets Tomas Winkler
2014-01-08 23:27   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140108232410.GA11300@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.usyskin@intel.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.