From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [PATCH 22/85] drivers: gpu: Mark functions as static in radeon_device.c Date: Wed, 8 Jan 2014 16:07:35 -0800 Message-ID: <20140109000735.GA23891@leaf> References: <8af55c93ab10b11d473f9c731eddd6710ae7a418.1389018324.git.rashika.kheria@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Alex Deucher Cc: Rashika Kheria , LKML , Maling list - DRI developers , Jerome Glisse , Alex Deucher , Dave Airlie , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org On Wed, Jan 08, 2014 at 11:40:28AM -0500, Alex Deucher wrote: > On Mon, Jan 6, 2014 at 10:21 AM, Rashika Kheria > wrote: > > Mark functions radeon_doorbell_init() and radeon_doorbell_fini() as > > static in drm/radeon/radeon_device.c because they are not used outs= ide > > this file. > > > > This eliminates the following warning in drm/radeon/radeon_device.c= : > > drivers/gpu/drm/radeon/radeon_device.c:252:5: warning: no previous = prototype for =E2=80=98radeon_doorbell_init=E2=80=99 [-Wmissing-prototy= pes] > > drivers/gpu/drm/radeon/radeon_device.c:281:6: warning: no previous = prototype for =E2=80=98radeon_doorbell_fini=E2=80=99 [-Wmissing-prototy= pes] > > > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett >=20 > I've pulled in a subset of these patches: > http://cgit.freedesktop.org/~agd5f/linux/log/?h=3Ddrm-next-3.14-wip > I held off on some of the others as I'd rather fix up the headers > properly rather than just cramming everything in radeon.h or > radeon-asic.h for now. Can you elaborate on which patches are putting functions in the wrong header, and what header you'd prefer to see them in? - Josh Triplett