All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] usb: gadget: gr_udc: debugfs functions return NULL on error
Date: Thu, 09 Jan 2014 05:39:37 +0000	[thread overview]
Message-ID: <20140109053936.GG1265@elgon.mountain> (raw)

Debugfs functions return NULL on error.  They return an ERR_PTR if you
don't have debugfs configured.

The way it's designed is that normally you are only supposed to test for
NULL.  In this code, if "dev->dfs_root" is an ERR_PTR then passing it to
debugfs_create_file() will not cause a problem because
debugfs_create_file() would also just a stub.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c
index 5f9c65959dd2..b34a52171568 100644
--- a/drivers/usb/gadget/gr_udc.c
+++ b/drivers/usb/gadget/gr_udc.c
@@ -226,13 +226,13 @@ static void gr_dfs_create(struct gr_udc *dev)
 	const char *name = "gr_udc_state";
 
 	dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), NULL);
-	if (IS_ERR(dev->dfs_root)) {
+	if (!dev->dfs_root) {
 		dev_err(dev->dev, "Failed to create debugfs directory\n");
 		return;
 	}
 	dev->dfs_state = debugfs_create_file(name, 0444, dev->dfs_root,
 					     dev, &gr_dfs_fops);
-	if (IS_ERR(dev->dfs_state))
+	if (!dev->dfs_state)
 		dev_err(dev->dev, "Failed to create debugfs file %s\n", name);
 }
 

             reply	other threads:[~2014-01-09  5:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09  5:39 Dan Carpenter [this message]
2014-01-09  6:01 ` [patch] usb: gadget: gr_udc: debugfs functions return NULL on error Greg Kroah-Hartman
2014-01-09  6:06 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140109053936.GG1265@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.