Re: Request a freeze exception for vlantag feature

[Andrey Borzenkov <arvidjaar@gmail.com>]

В Wed, 8 Jan 2014 16:57:28 -0200
Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> пишет:

> +
> +      inter->vlantag.pcp = vlantag >> 12;
> +      inter->vlantag.dei = (vlantag >> 11) & 0x1;
> +      inter->vlantag.vid = vlantag & 0x1fff;

That's 13 bits, not 12, right? And this really looks like
overengeneering - do you really want to be able to set static VLAN
priority bits? I do not think it belongs to grub.

> +
> +  if (grub_strcmp (args[3], "vlan") == 0)
> +    vlan_pos = 3;
> +
> +  if (grub_strcmp (args[4], "vlan") == 0)
> +    vlan_pos = 4;

May be it should really start using proper options at this point
keeping existing three argument form as legacy.

net_add_addr --if=... --addr=... --mask=... --vlan=... --hw=... card