From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH v2 6/7] drm/msm: Drop unnecessary mach include Date: Thu, 9 Jan 2014 00:13:52 -0800 Message-ID: <20140109081352.GI8285@quad.lixom.net> References: <1388438133-431-1-git-send-email-sboyd@codeaurora.org> <1388438133-431-7-git-send-email-sboyd@codeaurora.org> <20131231051558.GB14405@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f51.google.com ([209.85.160.51]:36685 "EHLO mail-pb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbaAIIPy (ORCPT ); Thu, 9 Jan 2014 03:15:54 -0500 Received: by mail-pb0-f51.google.com with SMTP id up15so2725178pbc.10 for ; Thu, 09 Jan 2014 00:15:54 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131231051558.GB14405@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Rob Clark , arm@kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , David Brown , Dave Airlie , "dri-devel@lists.freedesktop.org" On Mon, Dec 30, 2013 at 09:15:58PM -0800, Stephen Boyd wrote: > On 12/30, Rob Clark wrote: > > On Mon, Dec 30, 2013 at 8:12 PM, Rob Clark wrote: > > > On Mon, Dec 30, 2013 at 4:15 PM, Stephen Boyd wrote: > > >> This file doesn't use the clk_reset() API that is exposed in > > >> mach-msm's mach/clk.h file. Remove the include so that this > > >> driver can be compiled as part of the multi-platform kernel. > > > > > > Thanks! > > > > > > Signed-off-by: Rob Clark > > I think you mean Acked-by? Signed-off-by usually means you're > sending the patch along. I've held off applying this, but I have applied the others -- please merge this through the DRM tree since it will need to go on top of changes there. That also means that enabling the MSM DTM driver in a multiplatform kernel will cause build breakages until the equivalent patch has been picked up. Since it's not enabled by any defconfigs I'm not too worried, but it will show up on randconfigs. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Date: Thu, 9 Jan 2014 00:13:52 -0800 Subject: [PATCH v2 6/7] drm/msm: Drop unnecessary mach include In-Reply-To: <20131231051558.GB14405@codeaurora.org> References: <1388438133-431-1-git-send-email-sboyd@codeaurora.org> <1388438133-431-7-git-send-email-sboyd@codeaurora.org> <20131231051558.GB14405@codeaurora.org> Message-ID: <20140109081352.GI8285@quad.lixom.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Dec 30, 2013 at 09:15:58PM -0800, Stephen Boyd wrote: > On 12/30, Rob Clark wrote: > > On Mon, Dec 30, 2013 at 8:12 PM, Rob Clark wrote: > > > On Mon, Dec 30, 2013 at 4:15 PM, Stephen Boyd wrote: > > >> This file doesn't use the clk_reset() API that is exposed in > > >> mach-msm's mach/clk.h file. Remove the include so that this > > >> driver can be compiled as part of the multi-platform kernel. > > > > > > Thanks! > > > > > > Signed-off-by: Rob Clark > > I think you mean Acked-by? Signed-off-by usually means you're > sending the patch along. I've held off applying this, but I have applied the others -- please merge this through the DRM tree since it will need to go on top of changes there. That also means that enabling the MSM DTM driver in a multiplatform kernel will cause build breakages until the equivalent patch has been picked up. Since it's not enabled by any defconfigs I'm not too worried, but it will show up on randconfigs. -Olof