From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Sasha Levin <sasha.levin@oracle.com>,
mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: increase static allocations
Date: Thu, 9 Jan 2014 09:56:31 +0100 [thread overview]
Message-ID: <20140109085631.GC7572@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <20140108232322.GH20765@two.firstfloor.org>
On Thu, Jan 09, 2014 at 12:23:22AM +0100, Andi Kleen wrote:
> On Wed, Jan 08, 2014 at 03:10:55PM -0500, Sasha Levin wrote:
> > On 01/08/2014 02:51 PM, Andi Kleen wrote:
> > >Sasha Levin <sasha.levin@oracle.com> writes:
> > >
> > >>Fuzzing a recent kernel with a large configuration hits the static
> > >>allocation limits and disables lockdep.
> > >
> > >Doesn't that use a lot more memory? I thought lockdep preallocates.
> > >
> > >Doubling may be too aggressive.
> >
> > The patch adds about 4MB of memory usage, I didn't think it's too much for something
> > that is only enabled during debugging.
>
> Wasting 4MB is an issue.
>
> Linus' first Linux system had less total memory than that.
Meh.. if someone from the embedded people care we can add
CONFIG_BASE_SMALL option, until then I couldn't care less about 4m.
> >
> > If this is an issue, can I suggest making these values configurable in the .config
> > and just let users pick whatever they want?
>
> Better allocate it at boot time, using a boot parameter or somesuch.
wrongbot andi is at it again.. no that's far too late.
next prev parent reply other threads:[~2014-01-09 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 19:21 [PATCH] lockdep: increase static allocations Sasha Levin
2014-01-08 19:51 ` Andi Kleen
2014-01-08 20:10 ` Sasha Levin
2014-01-08 23:23 ` Andi Kleen
2014-01-09 8:56 ` Peter Zijlstra [this message]
2015-03-24 14:42 ` James Hogan
2014-02-28 19:32 ` Sasha Levin
2014-03-01 4:33 ` Mike Galbraith
2014-04-07 21:51 ` Sasha Levin
2014-04-08 9:10 ` Peter Zijlstra
2014-04-18 13:13 ` [tip:locking/core] lockdep: Increase " tip-bot for Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109085631.GC7572@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.