Re: [LTP] [PATCH] clone/clone08.c: check whether clone supports 7 arguments

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 2205 bytes --]

On Thursday 09 January 2014 09:10:52 Jan Stancek wrote:
> ----- Original Message -----
> 
> > From: "Mike Frysinger" <vapier@gentoo.org>
> > To: "Jan Stancek" <jstancek@redhat.com>
> > Cc: ltp-list@lists.sourceforge.net
> > Sent: Thursday, 9 January, 2014 2:51:42 PM
> > Subject: Re: [LTP] [PATCH] clone/clone08.c: check whether clone supports
> > 7 arguments
> > 
> > On Thursday 09 January 2014 08:23:48 Jan Stancek wrote:
> > > ----- Original Message -----
> > > 
> > > > From: "Mike Frysinger" <vapier@gentoo.org>
> > > > To: ltp-list@lists.sourceforge.net
> > > > Sent: Thursday, 9 January, 2014 2:03:38 PM
> > > > Subject: Re: [LTP] [PATCH] clone/clone08.c: check whether clone
> > > > supports 7	arguments
> > > > 
> > > > On Wednesday 08 January 2014 09:31:30 Zeng Linggang wrote:
> > > > > +AC_DEFUN([LTP_CHECK_CLONE7ARGS],[
> > > > > +AH_TEMPLATE(HAVE_CLONE7ARGS,
> > > > > +[Define to 1 if clone() supports 7 arguments.])
> > > > > +AC_MSG_CHECKING([for CLONE7ARGS])
> > > > > +AC_TRY_LINK([#define _GNU_SOURCE
> > > > > +		#include <sched.h>
> > > > > +		#include <stdlib.h>],
> > > > > +		[
> > > > > +		#if !defined(__ia64__)
> > > > > +		clone(NULL, NULL, 0, NULL, NULL, NULL, NULL);
> > > > > +		#endif
> > > > > +		],
> > > > > +		AC_DEFINE(HAVE_CLONE7ARGS) AC_MSG_RESULT(yes),
> > > > > AC_MSG_RESULT(no)) +])
> > > > 
> > > > you aren't really testing for "clone takes 7 args", you're testing
> > > > for "clone has varargs support".  rename the define (and use _ in
> > > > its name), and drop the
> > > > ia64 check as it isn't needed.
> > > 
> > > Why not? It should matter, according to clone(2) you should be using
> > > __clone2() on ia64: ia64
> > > 
> > >        On ia64, a different interface is used:
> > exactly.  why does a clone() test have any bearing at all on ia64
> > behavior ? the code that checks the define won't get used in the
> > __ia64__ case, so having
> > a define here is pointless.
> 
> I thought the check applies to whole ltp_clone, since that is what is
> called by testcases checking this define.

there's debate as to whether that's how we want to take things :).  we'll sort 
it out there.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 388 bytes --]

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list