From: Olaf Hering <olaf@aepfle.de>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, apw@canonical.com,
jasowang@redhat.com
Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service
Date: Thu, 9 Jan 2014 13:03:51 +0100 [thread overview]
Message-ID: <20140109120351.GA25423@aepfle.de> (raw)
In-Reply-To: <1389224915-8737-1-git-send-email-kys@microsoft.com>
On Wed, Jan 08, K. Y. Srinivasan wrote:
> +++ b/tools/hv/hv_fcopy_daemon.c
> + len = pread(fcopy_fd, buffer, (4096 * 2), 0);
> +
> + if (len <= 0) {
> + syslog(LOG_ERR, "Read error: %s\n", strerror(errno));
> + continue;
This could flood syslog. I think the error should be logged just once.
Maybe like this:
if (len <=0) {
if (!error) {
syslog(...);
error = HV_ERROR_NOT_SUPPORTED;
}
continue;
}
> + }
> + in_msg = (struct hv_fcopy_hdr *)buffer;
> +
> + switch (in_msg->operation) {
> + case START_FILE_COPY:
> + error = hv_start_fcopy((struct hv_start_fcopy *)in_msg);
Olaf
next prev parent reply other threads:[~2014-01-09 12:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 23:48 [PATCH 1/1] Drivers: hv: Implement the file copy service K. Y. Srinivasan
2014-01-08 23:15 ` Greg KH
2014-01-09 7:39 ` Dan Carpenter
2014-01-09 11:18 ` [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory "in context" " Victor Miasnikov
2014-01-09 18:55 ` KY Srinivasan
2014-01-09 20:09 ` Dan Carpenter
2014-01-09 20:14 ` gregkh
2014-01-09 21:13 ` KY Srinivasan
2014-01-09 21:05 ` KY Srinivasan
2014-01-10 9:40 ` Dan Carpenter
2014-01-09 12:03 ` Olaf Hering [this message]
2014-01-09 18:01 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109120351.GA25423@aepfle.de \
--to=olaf@aepfle.de \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.