From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Thu, 9 Jan 2014 12:06:07 +0100 Subject: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting Message-ID: <20140109120607.6a33bee5@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org According to the comment, the TBG_CNTRL_0 register must be set at the end of the mode change sequence. Signed-off-by: Jean-Francois Moine --- drivers/gpu/drm/i2c/tda998x_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 7dbbc6b..864b9f5 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -1073,9 +1073,6 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder, } } - /* must be last register set: */ - reg_clear(priv, REG_TBG_CNTRL_0, TBG_CNTRL_0_SYNC_ONCE); - /* * Always generate sync polarity relative to input sync and * revert input stage toggled sync at output stage @@ -1100,6 +1097,9 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder, if (priv->audio_type) tda998x_configure_audio(priv, mode); } + + /* must be last register set: */ + reg_write(priv, REG_TBG_CNTRL_0, 0); } static enum drm_connector_status -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting Date: Thu, 9 Jan 2014 12:06:07 +0100 Message-ID: <20140109120607.6a33bee5@armhf> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp1-g21.free.fr (smtp1-g21.free.fr [212.27.42.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23FA0FBCEB for ; Thu, 9 Jan 2014 03:12:12 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org QWNjb3JkaW5nIHRvIHRoZSBjb21tZW50LCB0aGUgVEJHX0NOVFJMXzAgcmVnaXN0ZXIgbXVzdCBi ZSBzZXQgYXQgdGhlCmVuZCBvZiB0aGUgbW9kZSBjaGFuZ2Ugc2VxdWVuY2UuCgpTaWduZWQtb2Zm LWJ5OiBKZWFuLUZyYW5jb2lzIE1vaW5lIDxtb2luZWpmQGZyZWUuZnI+Ci0tLQogZHJpdmVycy9n cHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jIHwgNiArKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2kyYy90ZGE5OTh4X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jCmlu ZGV4IDdkYmJjNmIuLjg2NGI5ZjUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pMmMvdGRh OTk4eF9kcnYuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5OHhfZHJ2LmMKQEAgLTEw NzMsOSArMTA3Myw2IEBAIHRkYTk5OHhfZW5jb2Rlcl9tb2RlX3NldChzdHJ1Y3QgZHJtX2VuY29k ZXIgKmVuY29kZXIsCiAJCX0KIAl9CiAKLQkvKiBtdXN0IGJlIGxhc3QgcmVnaXN0ZXIgc2V0OiAq LwotCXJlZ19jbGVhcihwcml2LCBSRUdfVEJHX0NOVFJMXzAsIFRCR19DTlRSTF8wX1NZTkNfT05D RSk7Ci0KIAkvKgogCSAqIEFsd2F5cyBnZW5lcmF0ZSBzeW5jIHBvbGFyaXR5IHJlbGF0aXZlIHRv IGlucHV0IHN5bmMgYW5kCiAJICogcmV2ZXJ0IGlucHV0IHN0YWdlIHRvZ2dsZWQgc3luYyBhdCBv dXRwdXQgc3RhZ2UKQEAgLTExMDAsNiArMTA5Nyw5IEBAIHRkYTk5OHhfZW5jb2Rlcl9tb2RlX3Nl dChzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIsCiAJCWlmIChwcml2LT5hdWRpb190eXBlKQog CQkJdGRhOTk4eF9jb25maWd1cmVfYXVkaW8ocHJpdiwgbW9kZSk7CiAJfQorCisJLyogbXVzdCBi ZSBsYXN0IHJlZ2lzdGVyIHNldDogKi8KKwlyZWdfd3JpdGUocHJpdiwgUkVHX1RCR19DTlRSTF8w LCAwKTsKIH0KIAogc3RhdGljIGVudW0gZHJtX2Nvbm5lY3Rvcl9zdGF0dXMKLS0gCktlbiBhciBj J2hlbnRhw7EJfAkgICAgICAqKiBCcmVpemggaGEgTGludXggYXRhdiEgKioKSmVmCQl8CQlodHRw Oi8vbW9pbmVqZi5mcmVlLmZyLwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754374AbaAILOl (ORCPT ); Thu, 9 Jan 2014 06:14:41 -0500 Received: from smtp1-g21.free.fr ([212.27.42.1]:39648 "EHLO smtp1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755822AbaAILMO convert rfc822-to-8bit (ORCPT ); Thu, 9 Jan 2014 06:12:14 -0500 Date: Thu, 9 Jan 2014 12:06:07 +0100 From: Jean-Francois Moine To: dri-devel@lists.freedesktop.org Cc: Dave Airlie , Rob Clark , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting Message-ID: <20140109120607.6a33bee5@armhf> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the comment, the TBG_CNTRL_0 register must be set at the end of the mode change sequence. Signed-off-by: Jean-Francois Moine --- drivers/gpu/drm/i2c/tda998x_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 7dbbc6b..864b9f5 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -1073,9 +1073,6 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder, } } - /* must be last register set: */ - reg_clear(priv, REG_TBG_CNTRL_0, TBG_CNTRL_0_SYNC_ONCE); - /* * Always generate sync polarity relative to input sync and * revert input stage toggled sync at output stage @@ -1100,6 +1097,9 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder, if (priv->audio_type) tda998x_configure_audio(priv, mode); } + + /* must be last register set: */ + reg_write(priv, REG_TBG_CNTRL_0, 0); } static enum drm_connector_status -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/