From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Thu, 09 Jan 2014 11:15:32 +0000 Subject: Re: [PATCH 0/8] ARM: shmobile: Conditionally select SMSC_PHY Message-Id: <201401091215.33255.arnd@arndb.de> List-Id: References: <1389084488-25984-1-git-send-email-horms+renesas@verge.net.au> <20140109051311.GH2132@verge.net.au> In-Reply-To: <20140109051311.GH2132@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thursday 09 January 2014, Simon Horman wrote: > On Tue, Jan 07, 2014 at 05:48:00PM +0900, Simon Horman wrote: > > Select the SMSC_PHY if ethernet is enabled on shmbile boards > > that have an SMSC phy. This allows the SMSC-specific phy driver > > to be used rather than relying on generic phy code. > > > > Based on the renesas-devel-v3.13-rc7-20140107 tag > > of my renesas tree. > > I have queued up these changes. > I don't have an objection to the patches themselves, but a general feeling that it would be better to have larger combined patches than splitting them out per board. I'm cautious with this comment because most people seem to do the opposite and combine too many things into large patches, but I think when you have identical changeset comments and change the same Kconfig file in all of them, you can save yourself and the reviewers some work. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 9 Jan 2014 12:15:32 +0100 Subject: [PATCH 0/8] ARM: shmobile: Conditionally select SMSC_PHY In-Reply-To: <20140109051311.GH2132@verge.net.au> References: <1389084488-25984-1-git-send-email-horms+renesas@verge.net.au> <20140109051311.GH2132@verge.net.au> Message-ID: <201401091215.33255.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 09 January 2014, Simon Horman wrote: > On Tue, Jan 07, 2014 at 05:48:00PM +0900, Simon Horman wrote: > > Select the SMSC_PHY if ethernet is enabled on shmbile boards > > that have an SMSC phy. This allows the SMSC-specific phy driver > > to be used rather than relying on generic phy code. > > > > Based on the renesas-devel-v3.13-rc7-20140107 tag > > of my renesas tree. > > I have queued up these changes. > I don't have an objection to the patches themselves, but a general feeling that it would be better to have larger combined patches than splitting them out per board. I'm cautious with this comment because most people seem to do the opposite and combine too many things into large patches, but I think when you have identical changeset comments and change the same Kconfig file in all of them, you can save yourself and the reviewers some work. Arnd