All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Antonios Motakis <a.motakis@virtualopensystems.com>
Cc: lukego@gmail.com, snabb-devel@googlegroups.com,
	n.nikolaev@virtualopensystems.com, qemu-devel@nongnu.org,
	tech@virtualopensystems.com
Subject: Re: [Qemu-devel] [PATCH v5 0/7] Vhost and vhost-net support for userspace based backends
Date: Thu, 9 Jan 2014 18:11:10 +0200	[thread overview]
Message-ID: <20140109161110.GD3485@redhat.com> (raw)
In-Reply-To: <1389279601-1924-1-git-send-email-a.motakis@virtualopensystems.com>

On Thu, Jan 09, 2014 at 03:59:54PM +0100, Antonios Motakis wrote:
> In this patch series we would like to introduce our approach for putting a
> virtio-net backend in an external userspace process. Our eventual target is to
> run the network backend in the Snabbswitch ethernet switch, while receiving
> traffic from a guest inside QEMU/KVM which runs an unmodified virtio-net
> implementation.
> 
> For this, we are working into extending vhost to allow equivalent functionality
> for userspace. Vhost already passes control of the data plane of virtio-net to
> the host kernel; we want to realize a similar model, but for userspace.
> 
> In this patch series the concept of a vhost-backend is introduced.
> 
> We define two vhost backend types - vhost-kernel and vhost-user. The former is
> the interface to the current kernel module implementation. Its control plane is
> ioctl based. The data plane is the kernel directly accessing the QEMU allocated,
> guest memory.
> 
> In the new vhost-user backend, the control plane is based on communication
> between QEMU and another userspace process using a unix domain socket. This
> allows to implement a virtio backend for a guest running in QEMU, inside the
> other userspace process.
> 
> We change -mem-path to QemuOpts and add prealloc, share and unlink as properties
> to it. HugeTLBFS requirements of -mem-path are relaxed, so any valid path can
> be used now. The new properties allow more fine grained control over the guest
> RAM backing store.
> 
> The data path is realized by directly accessing the vrings and the buffer data
> off the guest's memory.
> 
> The current user of vhost-user is only vhost-net. We add new netdev backend
> that is intended to initialize vhost-net with vhost-user backend.
> 
> Example usage:
> 
> qemu -m 1024 -mem-path /hugetlbfs,prealloc=on,share=on \
>      -netdev type=vhost-user,id=net0,file=/path/to/sock \


Why can't this use standard syntax that qemu_chr_open_socket
supports?
This will add features such as ability for management to open the socket
and pass it to qemu and switch, ability to switch server/client roles,
and others.


>      -device virtio-net-pci,netdev=net0
> 
> Changes from v4:
>  - Use error_report for errors
>  - VhostUserMsg has new field 'size' indicating the following payload length.
>    Field 'flags' now has version and reply bits. The structure is packed.
>  - Send data is of variable length ('size' field in message)
>  - Parse received calls in 2 steps, header and payload
>  - Add new message type VHOST_USER_ECHO, to check connection status
> 
> Changes from v3:
>  - Convert -mem-path to QemuOpts with prealloc, share and unlink properties
>  - Set 1 sec timeout when read/write to the unix domain socket
>  - Fix file descriptor leak
> 
> Changes from v2:
>  - Reconnect when the backend disappears
> 
> Changes from v1:
>  - Implementation of vhost-user netdev backend
>  - Code improvements
> 
> Antonios Motakis (7):
>   Convert -mem-path to QemuOpts and add prealloc,share and unlink
>     properties
>   Decouple vhost from kernel interface
>   Add vhost-user skeleton
>   Add domain socket communication for vhost-user backend
>   Add vhost-user calls implementation
>   Add new vhost-user netdev backend
>   Add vhost-user reconnection
> 
>  exec.c                            |  57 ++++-
>  hmp-commands.hx                   |   4 +-
>  hw/net/vhost_net.c                | 144 ++++++++---
>  hw/net/virtio-net.c               |  42 ++--
>  hw/scsi/vhost-scsi.c              |  13 +-
>  hw/virtio/Makefile.objs           |   2 +-
>  hw/virtio/vhost-backend.c         | 504 ++++++++++++++++++++++++++++++++++++++
>  hw/virtio/vhost.c                 |  46 ++--
>  include/exec/cpu-all.h            |   3 -
>  include/hw/virtio/vhost-backend.h |  40 +++
>  include/hw/virtio/vhost.h         |   4 +-
>  include/net/vhost-user.h          |  17 ++
>  include/net/vhost_net.h           |  15 +-
>  net/Makefile.objs                 |   2 +-
>  net/clients.h                     |   3 +
>  net/hub.c                         |   1 +
>  net/net.c                         |   2 +
>  net/tap.c                         |  16 +-
>  net/vhost-user.c                  | 167 +++++++++++++
>  qapi-schema.json                  |  18 +-
>  qemu-options.hx                   |  13 +-
>  vl.c                              |  41 +++-
>  22 files changed, 1030 insertions(+), 124 deletions(-)
>  create mode 100644 hw/virtio/vhost-backend.c
>  create mode 100644 include/hw/virtio/vhost-backend.h
>  create mode 100644 include/net/vhost-user.h
>  create mode 100644 net/vhost-user.c
> 
> -- 
> 1.8.3.2
> 

  parent reply	other threads:[~2014-01-09 16:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 14:59 [Qemu-devel] [PATCH v5 0/7] Vhost and vhost-net support for userspace based backends Antonios Motakis
2014-01-09 14:59 ` [Qemu-devel] [PATCH v5 1/7] Convert -mem-path to QemuOpts and add prealloc, share and unlink properties Antonios Motakis
2014-01-09 16:01   ` Michael S. Tsirkin
2014-01-10 11:05     ` Antonios Motakis
2014-01-10 12:31       ` Michael S. Tsirkin
2014-01-13  8:30   ` Edgar E. Iglesias
2014-01-09 14:59 ` [Qemu-devel] [PATCH v5 2/7] Decouple vhost from kernel interface Antonios Motakis
2014-01-09 14:59 ` [Qemu-devel] [PATCH v5 3/7] Add vhost-user skeleton Antonios Motakis
2014-01-09 14:59 ` [Qemu-devel] [PATCH v5 4/7] Add domain socket communication for vhost-user backend Antonios Motakis
2014-01-09 15:31   ` Michael S. Tsirkin
2014-01-10 11:09     ` Antonios Motakis
2014-01-09 14:59 ` [Qemu-devel] [PATCH v5 5/7] Add vhost-user calls implementation Antonios Motakis
2014-01-09 15:47   ` Michael S. Tsirkin
2014-01-10 11:07     ` Antonios Motakis
2014-01-09 15:00 ` [Qemu-devel] [PATCH v5 6/7] Add new vhost-user netdev backend Antonios Motakis
2014-01-09 16:14   ` Michael S. Tsirkin
2014-01-10 11:00     ` Antonios Motakis
2014-01-09 15:00 ` [Qemu-devel] [PATCH v5 7/7] Add vhost-user reconnection Antonios Motakis
2014-01-09 16:16   ` Michael S. Tsirkin
2014-01-10 10:59     ` Antonios Motakis
2014-01-10 12:29       ` Michael S. Tsirkin
2014-01-09 16:11 ` Michael S. Tsirkin [this message]
2014-01-10 10:58   ` [Qemu-devel] [PATCH v5 0/7] Vhost and vhost-net support for userspace based backends Antonios Motakis
2014-01-10 12:25     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140109161110.GD3485@redhat.com \
    --to=mst@redhat.com \
    --cc=a.motakis@virtualopensystems.com \
    --cc=lukego@gmail.com \
    --cc=n.nikolaev@virtualopensystems.com \
    --cc=qemu-devel@nongnu.org \
    --cc=snabb-devel@googlegroups.com \
    --cc=tech@virtualopensystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.