From: Dave Jones <davej@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Oleg Nesterov <oleg@redhat.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC][PATCH] lockdep: Introduce wait-type checks
Date: Thu, 9 Jan 2014 12:33:26 -0500 [thread overview]
Message-ID: <20140109173326.GA10105@redhat.com> (raw)
In-Reply-To: <20140109111516.GE7572@laptop.programming.kicks-ass.net>
On Thu, Jan 09, 2014 at 12:15:16PM +0100, Peter Zijlstra wrote:
> Subject: lockdep: Introduce wait-type checks
> From: Peter Zijlstra <peterz@infradead.org>
> Date: Tue, 19 Nov 2013 21:45:48 +0100
>
> This patch extends lockdep to validate lock wait-type context.
ooh, a new toy.
*boom*
[ 0.298629] =============================
[ 0.298732] [ BUG: Invalid wait context ]
[ 0.298834] 3.13.0-rc7+ #15 Not tainted
[ 0.298935] -----------------------------
[ 0.299038] swapper/0/1 is trying to lock:
[ 0.299135] (&n->list_lock){......}-{3:3}, at: [<ffffffff816dea54>] get_partial_node.isra.49+0x4d/0x228
[ 0.299453]
stack backtrace:
[ 0.299608] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.13.0-rc7+ #15
[ 0.299983] 0000000000000001 ffff880243f37a00 ffffffff816dfe5b 0000000000000014
[ 0.300302] ffff880243f37a78 ffffffff8109f1f7 0000000000000000 ffff880243f37a78
[ 0.300611] 0000000000000046 ffffffff81189ae3 ffffffff00000000 0000000000000046
[ 0.300927] Call Trace:
[ 0.301028] [<ffffffff816dfe5b>] dump_stack+0x4e/0x7a
[ 0.301128] [<ffffffff8109f1f7>] __lock_acquire.isra.28+0x3d7/0xd80
[ 0.301238] [<ffffffff81189ae3>] ? deactivate_slab+0x3c3/0x740
[ 0.301345] [<ffffffff810a030d>] lock_acquire+0x8d/0x120
[ 0.302971] [<ffffffff816dea54>] ? get_partial_node.isra.49+0x4d/0x228
[ 0.303077] [<ffffffff816e9e3b>] _raw_spin_lock+0x3b/0x50
[ 0.303183] [<ffffffff816dea54>] ? get_partial_node.isra.49+0x4d/0x228
[ 0.303290] [<ffffffff816dea54>] get_partial_node.isra.49+0x4d/0x228
[ 0.303397] [<ffffffff810cd482>] ? __module_text_address+0x12/0x60
[ 0.303502] [<ffffffff810d35ff>] ? is_module_text_address+0x2f/0x50
[ 0.303610] [<ffffffff81074548>] ? __kernel_text_address+0x58/0x80
[ 0.303717] [<ffffffff816dedfc>] __slab_alloc+0x1cd/0x562
[ 0.303821] [<ffffffff812e86ff>] ? alloc_cpumask_var_node+0x1f/0x90
[ 0.303929] [<ffffffff8118ab6a>] kmem_cache_alloc_node_trace+0xda/0x290
[ 0.304037] [<ffffffff812e86ff>] ? alloc_cpumask_var_node+0x1f/0x90
[ 0.304145] [<ffffffff812e86ff>] alloc_cpumask_var_node+0x1f/0x90
[ 0.304250] [<ffffffff812e879e>] alloc_cpumask_var+0xe/0x10
[ 0.304357] [<ffffffff81030990>] __assign_irq_vector+0x40/0x340
[ 0.304462] [<ffffffff810324a1>] __create_irqs+0x151/0x210
[ 0.304567] [<ffffffff810325a2>] create_irq+0x22/0x30
[ 0.304674] [<ffffffff815ab25d>] dmar_set_interrupt+0x2d/0xd0
[ 0.304784] [<ffffffff81d6a532>] enable_drhd_fault_handling+0x24/0x66
[ 0.304890] [<ffffffff81d6bc7f>] irq_remap_enable_fault_handling+0x26/0x30
[ 0.304999] [<ffffffff81d2f3e0>] bsp_end_local_APIC_setup+0x18/0x1a
[ 0.305106] [<ffffffff81d2d44a>] native_smp_prepare_cpus+0x35c/0x3d3
[ 0.305215] [<ffffffff81d20f93>] kernel_init_freeable+0x124/0x26c
[ 0.305321] [<ffffffff816d6d4e>] ? kernel_init+0xe/0x130
[ 0.305427] [<ffffffff816d6d40>] ? rest_init+0xd0/0xd0
[ 0.305529] [<ffffffff816d6d4e>] kernel_init+0xe/0x130
[ 0.305627] [<ffffffff816f23ac>] ret_from_fork+0x7c/0xb0
[ 0.305731] [<ffffffff816d6d40>] ? rest_init+0xd0/0xd0
[ 0.305836]
other info that might help us debug this:
[ 0.305993] 1 lock held by swapper/0/1:
[ 0.306093] #0: (vector_lock){......}-{2:2}, at: [<ffffffff8103245c>] __create_irqs+0x10c/0x210
[ 0.306444]
stack backtrace:
[ 0.306599] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.13.0-rc7+ #15
[ 0.306972] 0000000000000001 ffff880243f37a00 ffffffff816dfe5b 0000000000000014
[ 0.307282] ffff880243f37a78 ffffffff8109f220 0000000000000000 ffff880243f37a78
[ 0.307594] 0000000000000046 ffffffff81189ae3 ffffffff00000000 0000000000000046
[ 0.307903] Call Trace:
[ 0.307999] [<ffffffff816dfe5b>] dump_stack+0x4e/0x7a
[ 0.308103] [<ffffffff8109f220>] __lock_acquire.isra.28+0x400/0xd80
[ 0.308209] [<ffffffff81189ae3>] ? deactivate_slab+0x3c3/0x740
[ 0.308316] [<ffffffff810a030d>] lock_acquire+0x8d/0x120
[ 0.308422] [<ffffffff816dea54>] ? get_partial_node.isra.49+0x4d/0x228
[ 0.308529] [<ffffffff816e9e3b>] _raw_spin_lock+0x3b/0x50
[ 0.308631] [<ffffffff816dea54>] ? get_partial_node.isra.49+0x4d/0x228
[ 0.308735] [<ffffffff816dea54>] get_partial_node.isra.49+0x4d/0x228
[ 0.308843] [<ffffffff810cd482>] ? __module_text_address+0x12/0x60
[ 0.308949] [<ffffffff810d35ff>] ? is_module_text_address+0x2f/0x50
[ 0.309055] [<ffffffff81074548>] ? __kernel_text_address+0x58/0x80
[ 0.309161] [<ffffffff816dedfc>] __slab_alloc+0x1cd/0x562
[ 0.309265] [<ffffffff812e86ff>] ? alloc_cpumask_var_node+0x1f/0x90
[ 0.309372] [<ffffffff8118ab6a>] kmem_cache_alloc_node_trace+0xda/0x290
[ 0.309479] [<ffffffff812e86ff>] ? alloc_cpumask_var_node+0x1f/0x90
[ 0.309586] [<ffffffff812e86ff>] alloc_cpumask_var_node+0x1f/0x90
[ 0.309692] [<ffffffff812e879e>] alloc_cpumask_var+0xe/0x10
[ 0.309799] [<ffffffff81030990>] __assign_irq_vector+0x40/0x340
[ 0.309906] [<ffffffff810324a1>] __create_irqs+0x151/0x210
[ 0.310005] [<ffffffff810325a2>] create_irq+0x22/0x30
[ 0.310109] [<ffffffff815ab25d>] dmar_set_interrupt+0x2d/0xd0
[ 0.310215] [<ffffffff81d6a532>] enable_drhd_fault_handling+0x24/0x66
[ 0.310321] [<ffffffff81d6bc7f>] irq_remap_enable_fault_handling+0x26/0x30
[ 0.310429] [<ffffffff81d2f3e0>] bsp_end_local_APIC_setup+0x18/0x1a
[ 0.310536] [<ffffffff81d2d44a>] native_smp_prepare_cpus+0x35c/0x3d3
[ 0.310644] [<ffffffff81d20f93>] kernel_init_freeable+0x124/0x26c
[ 0.310746] [<ffffffff816d6d4e>] ? kernel_init+0xe/0x130
[ 0.310852] [<ffffffff816d6d40>] ? rest_init+0xd0/0xd0
[ 0.310955] [<ffffffff816d6d4e>] kernel_init+0xe/0x130
[ 0.311058] [<ffffffff816f23ac>] ret_from_fork+0x7c/0xb0
[ 0.311164] [<ffffffff816d6d40>] ? rest_init+0xd0/0xd0
nitpick: Why is the backtrace printed twice ?
Dave
next prev parent reply other threads:[~2014-01-09 17:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 11:15 [RFC][PATCH] lockdep: Introduce wait-type checks Peter Zijlstra
2014-01-09 11:49 ` Peter Zijlstra
2014-01-09 16:31 ` Oleg Nesterov
2014-01-09 17:08 ` Peter Zijlstra
2014-01-09 17:54 ` check && lockdep_no_validate (Was: lockdep: Introduce wait-type checks) Oleg Nesterov
2014-01-12 20:58 ` Peter Zijlstra
2014-01-13 16:07 ` Oleg Nesterov
2014-01-16 17:43 ` Oleg Nesterov
2014-01-16 18:09 ` Peter Zijlstra
2014-01-16 20:26 ` Alan Stern
2014-01-17 16:31 ` Oleg Nesterov
2014-01-17 18:01 ` Alan Stern
2014-01-20 18:19 ` [PATCH 0/5] lockdep: (Was: check && lockdep_no_validate) Oleg Nesterov
2014-01-20 18:20 ` [PATCH 1/5] lockdep: make held_lock->check and "int check" argument bool Oleg Nesterov
2014-02-10 13:32 ` [tip:core/locking] lockdep: Make " tip-bot for Oleg Nesterov
2014-01-20 18:20 ` [PATCH 2/5] lockdep: don't create the wrong dependency on hlock->check == 0 Oleg Nesterov
2014-02-10 13:33 ` [tip:core/locking] lockdep: Don' t " tip-bot for Oleg Nesterov
2014-01-20 18:20 ` [PATCH 3/5] lockdep: change mark_held_locks() to check hlock->check instead of lockdep_no_validate Oleg Nesterov
2014-02-10 13:33 ` [tip:core/locking] lockdep: Change " tip-bot for Oleg Nesterov
2014-01-20 18:20 ` [PATCH 4/5] lockdep: change lockdep_set_novalidate_class() to use _and_name Oleg Nesterov
2014-02-10 13:33 ` [tip:core/locking] lockdep: Change " tip-bot for Oleg Nesterov
2014-01-20 18:20 ` [PATCH 5/5] lockdep: pack subclass/trylock/read/check into a single argument Oleg Nesterov
2014-01-21 14:10 ` Peter Zijlstra
2014-01-21 17:27 ` Oleg Nesterov
2014-01-21 17:35 ` Dave Jones
2014-01-21 18:43 ` Oleg Nesterov
2014-01-21 18:53 ` Steven Rostedt
2014-01-21 20:06 ` Oleg Nesterov
2014-01-21 19:39 ` uninline rcu_lock_acquire/etc ? Oleg Nesterov
2014-01-22 3:54 ` Paul E. McKenney
2014-01-22 18:31 ` Oleg Nesterov
2014-01-22 19:34 ` Paul E. McKenney
2014-01-22 19:39 ` Oleg Nesterov
2014-01-20 18:37 ` [PATCH 0/5] lockdep: (Was: check && lockdep_no_validate) Alan Stern
2014-01-20 18:54 ` Oleg Nesterov
2014-01-20 21:42 ` Alan Stern
2014-01-12 9:40 ` [RFC][PATCH] lockdep: Introduce wait-type checks Ingo Molnar
2014-01-12 17:45 ` [PATCH 0/1] lockdep: Kill held_lock->check and "int check" arg of __lock_acquire() Oleg Nesterov
2014-01-12 17:45 ` [PATCH 1/1] " Oleg Nesterov
2014-01-13 0:28 ` Dave Jones
2014-01-13 16:20 ` Oleg Nesterov
2014-01-13 17:06 ` Oleg Nesterov
2014-01-13 17:28 ` Peter Zijlstra
2014-01-13 18:52 ` Oleg Nesterov
2014-01-13 22:34 ` Paul E. McKenney
2014-01-12 20:00 ` [PATCH 0/1] " Peter Zijlstra
2014-01-13 18:35 ` Oleg Nesterov
2014-01-09 17:33 ` Dave Jones [this message]
2014-01-09 22:12 ` [RFC][PATCH] lockdep: Introduce wait-type checks Peter Zijlstra
2014-01-10 12:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109173326.GA10105@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.