From: Sebastian Reichel <sre@ring0.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Marcel Holtmann" <marcel@holtmann.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Ивайло Димитров" <freemangordon@abv.bg>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-bluetooth@vger.kernel.org development"
<linux-bluetooth@vger.kernel.org>,
"Ville Tervo" <ville.tervo@nokia.com>
Subject: Re: [PATCH v4] Bluetooth: Add hci_h4p driver
Date: Fri, 10 Jan 2014 01:32:31 +0100 [thread overview]
Message-ID: <20140110003231.GA14141@earth.universe> (raw)
In-Reply-To: <20140109233843.GB19974@amd.pavel.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
Hi Pavel,
On Fri, Jan 10, 2014 at 12:38:43AM +0100, Pavel Machek wrote:
> > Here are some cleanup suggestions for probe, removal & module
> > initialization functions.
>
> ...and here's the patch implementing those suggestions. Thanks!
That looks right, but you forgot to cleanup hci_h4p_remove. Also I
suggest to simply merge this as v5.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-10 0:32 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 19:01 [PATCH] Bluetooth: Add hci_h4p driver Pali Rohár
2013-10-17 20:25 ` Pali Rohár
2013-10-17 22:11 ` Marcel Holtmann
[not found] ` <201310180739.47841@pali>
2013-10-18 8:56 ` Marcel Holtmann
2013-10-18 10:30 ` Pali Rohár
2013-10-24 16:41 ` Pali Rohár
2013-10-24 18:41 ` Joe Perches
2013-10-26 19:28 ` Pali Rohár
2013-12-27 11:02 ` [PATCH v2] " Pali Rohár
2013-12-27 11:34 ` Pali Rohár
2013-12-28 1:21 ` Marcel Holtmann
2013-12-30 12:13 ` Pavel Machek
2013-12-30 12:25 ` Pavel Machek
2013-12-30 13:19 ` Sebastian Reichel
2013-12-30 14:04 ` Pali Rohár
2013-12-30 13:54 ` Pali Rohár
2013-12-30 12:23 ` Pavel Machek
2013-12-30 14:31 ` Pali Rohár
2013-12-30 14:52 ` Sebastian Reichel
2013-12-30 23:42 ` Sebastian Reichel
2014-01-08 21:36 ` Pali Rohár
2014-01-08 21:36 ` Pali Rohár
2014-02-13 15:33 ` Pali Rohár
2014-02-13 15:33 ` Pali Rohár
2014-02-14 17:28 ` Sebastian Reichel
2014-02-15 22:30 ` Pavel Machek
2014-02-19 1:12 ` Ben Hutchings
2013-12-30 22:18 ` Pavel Machek
2013-12-30 22:19 ` [PATCH] wilink: mention name of module in help text Pavel Machek
2013-12-30 22:28 ` [PATCH v2] Bluetooth: Add hci_h4p driver Pavel Machek
2013-12-30 22:48 ` Pavel Machek
2013-12-31 22:12 ` Pavel Machek
2013-12-31 23:23 ` Marcel Holtmann
2014-01-01 20:09 ` Pavel Machek
2014-01-02 16:18 ` [PATCH v3] " Pavel Machek
2014-01-02 16:34 ` Marcel Holtmann
2014-01-03 0:17 ` [PATCH v4] " Pavel Machek
2014-01-03 1:05 ` Sebastian Reichel
2014-01-05 22:32 ` Pavel Machek
2014-01-05 23:01 ` Sebastian Reichel
2014-01-06 0:27 ` Pavel Machek
2014-01-03 1:36 ` Sebastian Reichel
2014-01-09 23:38 ` Pavel Machek
2014-01-10 0:32 ` Sebastian Reichel [this message]
2014-01-10 12:18 ` Pavel Machek
2014-01-10 13:44 ` Sebastian Reichel
2014-01-10 14:49 ` Pavel Machek
2014-01-10 14:52 ` [PATCH v5] " Pavel Machek
2014-01-10 17:33 ` Joe Perches
2014-01-11 0:19 ` Pavel Machek
2014-01-11 0:28 ` [PATCH v6] " Pavel Machek
2014-01-16 0:22 ` Pavel Machek
2014-01-16 3:01 ` Marcel Holtmann
2014-01-17 12:14 ` Pavel Machek
2014-01-17 13:29 ` [PATCH v7] staging/bluetooth: " Pavel Machek
2014-01-17 13:34 ` [PATCH] Bluetooth: add module name for btwilink Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110003231.GA14141@earth.universe \
--to=sre@ring0.de \
--cc=freemangordon@abv.bg \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.