Re: [PATCH] ASoC: fsl: imx-wm8962: Grant hw_params() permission to reprogram FLL

[Nicolin Chen <Guangyu.Chen@freescale.com>]

On Thu, Jan 09, 2014 at 06:25:51PM +0000, Mark Brown wrote:
> > +	mask = WM8962_MIXINL_TO_HPMIXL_MASK | WM8962_MIXINR_TO_HPMIXL_MASK |
> > +		WM8962_IN4L_TO_HPMIXL_MASK | WM8962_IN4R_TO_HPMIXL_MASK;
> > +	ret |= snd_soc_read(codec, WM8962_HEADPHONE_MIXER_1) & mask;
> > +	ret |= snd_soc_read(codec, WM8962_HEADPHONE_MIXER_2) & mask;
> > +	ret |= snd_soc_read(codec, WM8962_SPEAKER_MIXER_1) & mask;
> > +	ret |= snd_soc_read(codec, WM8962_SPEAKER_MIXER_2) & mask;
> 
> Peering inside the CODEC register map isn't great and given that we

Hmm..It looks like it'd be safer to give up the bypass checking here.

> implement bias level changes for non-CPU paths immediately I'm not sure
> what that's giving you over just using the bias level (which is the way
> you're supposed to check if the CODEC is active)?

Aha, I also feel myself a bit obsessed to this modification while knowing
so well that you're not very into it. But it might be just because, at
least to me and according to our SRS of Linux BSP, the flexibility and
capability here is more important than the extra function - bypass paths.
(No offense taken, just my own feeling from the angle of a common user.)

I'll still try to refine this patch to a new version. And meanwhile, I
will listen your reply to this mail and see if I should send it or not.

Thank you,
Nicolin Chen