From: Richard Cochran <richardcochran@gmail.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [net-next 14/16] i40e: enable PTP
Date: Fri, 10 Jan 2014 12:26:18 +0100 [thread overview]
Message-ID: <20140110112618.GA32563@localhost.localdomain> (raw)
In-Reply-To: <1389344336-1558-15-git-send-email-jeffrey.t.kirsher@intel.com>
On Fri, Jan 10, 2014 at 12:58:54AM -0800, Jeff Kirsher wrote:
> +/**
> + * i40e_ptp_enable - Enable/disable ancillary features of the PHC subsystem
> + * @ptp: The PTP clock structure
> + * @rq: The requested feature to change
> + * @on: Enable/disable flag
> + *
> + * The XL710 does not support any of the ancillary features of the PHY
> + * subsystem, so this function may just return.
> + **/
Typo, PHC subsystem? Otherwise, the driver looks good to me.
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2014-01-10 11:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 8:58 [net-next 00/16][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-01-10 8:58 ` [net-next 01/16] i40e: use assignment instead of memcpy Jeff Kirsher
2014-01-10 8:58 ` [net-next 02/16] i40e: drop unused macros Jeff Kirsher
2014-01-10 8:58 ` [net-next 03/16] i40e: Update the Current NVM version Low value Jeff Kirsher
2014-01-10 8:58 ` [net-next 04/16] i40e: Bump version Jeff Kirsher
2014-01-10 8:58 ` [net-next 05/16] i40e: fix long lines Jeff Kirsher
2014-01-10 9:07 ` Joe Perches
2014-01-10 10:02 ` David Laight
2014-01-10 10:35 ` Joe Perches
2014-01-10 18:05 ` Williams, Mitch A
2014-01-10 18:14 ` Joe Perches
2014-01-10 18:20 ` Williams, Mitch A
2014-01-10 8:58 ` [net-next 06/16] i40e: Cleanup Doxygen warnings Jeff Kirsher
2014-01-10 8:58 ` [net-next 07/16] i40e: Setting queue count to 1 using ethtool is valid Jeff Kirsher
2014-01-10 8:58 ` [net-next 08/16] i40e: do not bail when disabling if Tx queue disable fails Jeff Kirsher
2014-01-10 8:58 ` [net-next 09/16] i40e: allow VF to remove any MAC filter Jeff Kirsher
2014-01-10 8:58 ` [net-next 10/16] i40e: check for possible incorrect ipv6 checksum Jeff Kirsher
2014-01-10 8:58 ` [net-next 11/16] i40e: adjust ITR max and min values Jeff Kirsher
2014-01-10 8:58 ` [net-next 12/16] i40e: clear qtx_head before enabling Tx queue Jeff Kirsher
2014-01-10 8:58 ` [net-next 13/16] i40e: call clear_pxe after adminq is initialized Jeff Kirsher
2014-01-10 8:58 ` [net-next 14/16] i40e: enable PTP Jeff Kirsher
2014-01-10 11:26 ` Richard Cochran [this message]
2014-01-10 15:55 ` Ben Hutchings
2014-01-10 16:48 ` Keller, Jacob E
2014-01-10 8:58 ` [net-next 15/16] i40e: fix log message wording Jeff Kirsher
2014-01-10 8:58 ` [net-next 16/16] i40e: Bump version Jeff Kirsher
2014-01-10 17:48 ` [net-next 00/16][pull request] Intel Wired LAN Driver Updates David Miller
2014-01-10 17:56 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110112618.GA32563@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.