From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftables PATCH next-3.14] expr: fix registers datatypes
Date: Fri, 10 Jan 2014 13:42:39 +0100 [thread overview]
Message-ID: <20140110124239.GA7388@localhost> (raw)
In-Reply-To: <20140110120751.9047.7872.stgit@nfdev.cica.es>
On Fri, Jan 10, 2014 at 01:07:51PM +0100, Arturo Borrero Gonzalez wrote:
> Registers datatypes must be enum nft_registers.
>
> Pablo Neira says:
> << From the kernel representation point of view, it doesn't make any
> sense to have set both sreg and dreg, but we should not make such
> assumption from userspace. If the user sets both sreg and dreg, it's
> wrong and the kernel should reply -EINVAL so the user knows that it
> has to fix its userspace code. This requires a bit more memory in
> userspace, but we don't have the memory restrictions that we have in
> kernelspace, so a bit more consumption won't harm. >>
>
> So, while at it, delete the meta expr union for registers.
Need a fix for this in master, I forgot to specify. I just sent several
patches. Thanks anyway.
prev parent reply other threads:[~2014-01-10 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 12:07 [libnftables PATCH next-3.14] expr: fix registers datatypes Arturo Borrero Gonzalez
2014-01-10 12:42 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110124239.GA7388@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.