All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Alex Gal <a.gal@motsai.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] wl12xx: fix tx power setting
Date: Fri, 10 Jan 2014 09:34:03 -0500	[thread overview]
Message-ID: <20140110143403.GD2131@tuxdriver.com> (raw)
In-Reply-To: <CAN44aq1AQYHDUsU6wVf01NcWS9EWnJe0BwF+Ygv1kqZ7M8AwgA@mail.gmail.com>

On Thu, Jan 09, 2014 at 02:02:00PM -0500, Alex Gal wrote:
> Sorry for the previous format.
> 
> Fixes wl12xx tx power.
> 
> Signed-off-by: Alex Gal <a.gal@motsai.com>
> ---
>  drivers/net/wireless/ti/wlcore/main.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/wireless/ti/wlcore/main.c
> b/drivers/net/wireless/ti/wlcore/main.c
> index e9da47c..cbbfc50 100644
> --- a/drivers/net/wireless/ti/wlcore/main.c
> +++ b/drivers/net/wireless/ti/wlcore/main.c
> @@ -4457,6 +4457,16 @@ static void wl1271_op_bss_info_changed(struct
> ieee80211_hw *hw,
>         if (ret < 0)
>                 goto out;
> 
> +       if ((changed & BSS_CHANGED_TXPOWER) &&
> +               bss_conf->txpower != wlvif->power_level) {

The prevailing style would be to align the bss_conf clause to start
under the second parenthesis in the line above.

> +
> +               ret = wl1271_acx_tx_power(wl, wlvif, bss_conf->txpower);
> +               if (ret < 0)
> +                       goto out;
> +
> +               wlvif->power_level = bss_conf->txpower;
> +       }
> +
>         if (is_ap)
>                 wl1271_bss_info_changed_ap(wl, vif, bss_conf, changed);
>         else
> -- 
> 1.8.5.2
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

      reply	other threads:[~2014-01-10 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 19:02 [PATCH v3] wl12xx: fix tx power setting Alex Gal
2014-01-10 14:34 ` John W. Linville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140110143403.GD2131@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=a.gal@motsai.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.