From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 2/2] i2c: Add bus driver for for OSIF USB i2c device. Date: Fri, 10 Jan 2014 19:01:54 +0100 Message-ID: <20140110180154.GK9681@lunn.ch> References: <20140104222842.GF3150@katana> <1388980536-7588-1-git-send-email-andrew@lunn.ch> <1388980536-7588-2-git-send-email-andrew@lunn.ch> <20140109214930.GC3866@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140109214930.GC3866@katana> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: Andrew Lunn , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Emmanuel Deloget , Barry Carter List-Id: linux-i2c@vger.kernel.org Hi Wolfgang > > +static u32 usb_func(struct i2c_adapter *adapter) > > +{ > > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > Have you tried SMBUS_QUICK by the way? Nope, not tried it. Documentation/i2c/smbus-protocol say: SMBus Quick Command =================== This sends a single bit to the device, at the place of the Rd/Wr bit. A Addr Rd/Wr [A] P Functionality flag: I2C_FUNC_SMBUS_QUICK My first question is probably silly. Should the first A be an S? So is this a zero byte transfer? Is that not what i2cdetect does? I've used i2cdetect on this hardware to find my devices. Thanks Andrew