All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Philip Oakley <philipoakley@iee.org>
Cc: GitList <git@vger.kernel.org>
Subject: Re: [PATCH 0/6] Make 'git help everyday' work
Date: Fri, 10 Jan 2014 12:19:57 -0800	[thread overview]
Message-ID: <20140110201957.GJ4776@google.com> (raw)
In-Reply-To: <1389309192-5748-1-git-send-email-philipoakley@iee.org>

Hi,

Philip Oakley wrote:

> The "Everyday GIT With 20 Commands Or So" guide is not accessible
> via the git help system. Fix that.

Neat. :)

Junio covered everything I'd want to say about patch 1/6.

After fixing that, I'd suggest squashing all 6 patches into a single
patch.  They all are part of accomplishing the same task, they are not
too hard to read together, and the intermediate state after applying a
few but not the rest doesn't make much sense.  The details of patches
2-6/6 look good to me.

Alternatively, this could be two patches:

 1 - modify everyday.txt in place to be a suitable manpage
 2 - rename it, add a placeholder for the old name, and modify the
     build rules to treat it as an actual manpage

Hope that helps,
Jonathan

      parent reply	other threads:[~2014-01-10 20:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 23:13 [PATCH 0/6] Make 'git help everyday' work Philip Oakley
2014-01-09 23:13 ` [PATCH 1/6] copy everyday.txt to giteveryday.txt Philip Oakley
2014-01-09 23:13 ` [PATCH 2/6] Update giteveryday.txt to fit man page formatting Philip Oakley
2014-01-09 23:13 ` [PATCH 3/6] add giteveryday to the manpages make list Philip Oakley
2014-01-09 23:13 ` [PATCH 4/6] Add deprecation note to old everyday.txt Philip Oakley
2014-01-09 23:13 ` [PATCH 5/6] add 'everyday' to the help --guides list Philip Oakley
2014-01-09 23:13 ` [PATCH 6/6] Update git(1) link to giteveryday Philip Oakley
2014-01-09 23:49 ` [PATCH 0/6] Make 'git help everyday' work Junio C Hamano
2014-01-10  8:06   ` Philip Oakley
2014-01-10 18:09     ` Junio C Hamano
2014-01-10 18:59       ` Philip Oakley
2014-01-11 19:50       ` Philip Oakley
2014-01-10  8:18   ` Stefan Näwe
2014-01-16 21:14     ` [PATCH 0/6] Make 'git help everyday' work -> relnotes Philip Oakley
2014-01-17 11:59       ` Stefan Näwe
2014-01-21 22:25         ` Philip Oakley
2014-01-21 23:28           ` Junio C Hamano
2014-01-22  0:22             ` Philip Oakley
2014-01-22  0:40               ` Junio C Hamano
2014-01-22  8:33                 ` Philip Oakley
2014-01-10 20:19 ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140110201957.GJ4776@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=philipoakley@iee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.