From: Olaf Hering <olaf@aepfle.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: david.vrabel@citrix.com, xen-devel@lists.xen.org,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen-blkfront: remove type check from blkfront_setup_discard
Date: Fri, 10 Jan 2014 23:49:27 +0100 [thread overview]
Message-ID: <20140110224927.GA14824@aepfle.de> (raw)
In-Reply-To: <52D073F0.5020400@oracle.com>
On Fri, Jan 10, Boris Ostrovsky wrote:
> I think we should at clear feature_discard and print an error in the log if
> *either* of xenbus_gather() calls fail.
Are you sure about that? AFAIK many other properties are optional as
well. I dont think there is a formal spec about the discard related
properties. Should every backend be required to provide all four
properties?
Olaf
next prev parent reply other threads:[~2014-01-10 22:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 16:28 [PATCH] xen-blkfront: remove type check from blkfront_setup_discard Olaf Hering
2014-01-10 18:07 ` Boris Ostrovsky
2014-01-10 18:07 ` Boris Ostrovsky
2014-01-10 21:37 ` Olaf Hering
2014-01-10 22:28 ` Boris Ostrovsky
2014-01-10 22:49 ` Olaf Hering [this message]
2014-01-10 22:57 ` Boris Ostrovsky
2014-01-10 22:57 ` [Xen-devel] " Boris Ostrovsky
2014-01-10 22:49 ` Olaf Hering
2014-01-13 9:30 ` Olaf Hering
2014-01-13 14:51 ` Boris Ostrovsky
2014-01-13 14:51 ` Boris Ostrovsky
2014-01-13 16:24 ` Konrad Rzeszutek Wilk
2014-01-13 16:24 ` Konrad Rzeszutek Wilk
2014-01-13 23:07 ` Olaf Hering
2014-01-13 23:07 ` Olaf Hering
2014-01-14 2:11 ` Boris Ostrovsky
2014-01-14 2:11 ` Boris Ostrovsky
2014-01-14 10:46 ` David Vrabel
2014-01-14 10:46 ` David Vrabel
2014-01-13 9:30 ` Olaf Hering
2014-01-10 22:28 ` Boris Ostrovsky
2014-01-10 21:37 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110224927.GA14824@aepfle.de \
--to=olaf@aepfle.de \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.