From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: Add .determine_rate to composite clk
Date: Sat, 11 Jan 2014 11:28:43 +0100 [thread overview]
Message-ID: <20140111102843.GU2941@lukather> (raw)
In-Reply-To: <CAJiWf8W6rCnnF9Tv+cpcqqshEb4ALD+J_RnYeLkaNVG-Rcd+QA@mail.gmail.com>
Hi Lemon,
On Sat, Jan 11, 2014 at 05:15:58PM +0800, Lemon Dai wrote:
> Hi Mike,
>
> As .determine_rate was added to struct clk and clk_mux_ops, maybe we
> should also copy determine_rate operation from mux_ops to
> clk_composite_ops in clk_register_composite( ),
> to make composite clk implementation more generic.
A similar patch is on its way to 3.14 already (commit 107f3198 in
Mike's clk-next branch).
Also, for future contributions, I'd suggest to read the
Documentation/SubmittingPatches file. Your patch had several style
issues that are covered in this file.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140111/9c6994f3/attachment.sig>
next prev parent reply other threads:[~2014-01-11 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 9:15 Add .determine_rate to composite clk Lemon Dai
2014-01-11 10:28 ` Maxime Ripard [this message]
[not found] ` <CAJiWf8WJxf0S32bPiXGUu3Rwmh36xYdbd0VEpLTG-pwyvVnasg@mail.gmail.com>
2014-01-14 14:08 ` Lemon Dai
2014-01-14 21:03 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140111102843.GU2941@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.