From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id D6A8A7F3F for ; Sat, 11 Jan 2014 05:10:54 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id C89908F8054 for ; Sat, 11 Jan 2014 03:10:51 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by cuda.sgi.com with ESMTP id s1kBt5AIhMhmGIKl (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Sat, 11 Jan 2014 03:10:50 -0800 (PST) Date: Sat, 11 Jan 2014 03:10:45 -0800 From: Christoph Hellwig Subject: Re: [xfs] c91c46c12: xfstests generic/313 regression Message-ID: <20140111111045.GA29380@infradead.org> References: <20140110122700.GA12624@localhost> <52CFF402.5080409@oracle.com> <20140110133306.GA22918@infradead.org> <52CFFD1C.7050005@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <52CFFD1C.7050005@oracle.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jeff Liu Cc: Christoph Hellwig , fengguang.wu@intel.com, LKML , "xfs@oss.sgi.com" On Fri, Jan 10, 2014 at 10:01:00PM +0800, Jeff Liu wrote: > I also thought to fix this problem in this way, however I'm not sure > if those flags can be set back to iattr->ia_valid internally... > > Otherwise, this fix looks good to me. Nothing in the truncate or open code path (or non-size setattr for that matter) looks at ia_valid after calling the filesystem, and they really have no business to. In the meantime this has passed xfstests, so I'll send it along. Thanks for the first fix, btw! _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbaAKLKw (ORCPT ); Sat, 11 Jan 2014 06:10:52 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:44103 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbaAKLKu (ORCPT ); Sat, 11 Jan 2014 06:10:50 -0500 Date: Sat, 11 Jan 2014 03:10:45 -0800 From: Christoph Hellwig To: Jeff Liu Cc: Christoph Hellwig , fengguang.wu@intel.com, LKML , "xfs@oss.sgi.com" Subject: Re: [xfs] c91c46c12: xfstests generic/313 regression Message-ID: <20140111111045.GA29380@infradead.org> References: <20140110122700.GA12624@localhost> <52CFF402.5080409@oracle.com> <20140110133306.GA22918@infradead.org> <52CFFD1C.7050005@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52CFFD1C.7050005@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2014 at 10:01:00PM +0800, Jeff Liu wrote: > I also thought to fix this problem in this way, however I'm not sure > if those flags can be set back to iattr->ia_valid internally... > > Otherwise, this fix looks good to me. Nothing in the truncate or open code path (or non-size setattr for that matter) looks at ia_valid after calling the filesystem, and they really have no business to. In the meantime this has passed xfstests, so I'll send it along. Thanks for the first fix, btw!