From: Andrew Morton <akpm@linux-foundation.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: kernel test robot <fengguang.wu@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [percpu_counter] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:3537 check_flags()
Date: Sat, 11 Jan 2014 12:48:41 -0800 [thread overview]
Message-ID: <20140111124841.00cd5893.akpm@linux-foundation.org> (raw)
In-Reply-To: <CACVXFVNiOB3KE71kEJtEmi5GQ6QEUoftht308mvgsts8VCP5HQ@mail.gmail.com>
On Sun, 12 Jan 2014 00:36:07 +0800 Ming Lei <tom.leiming@gmail.com> wrote:
> >
> > [ 8.093354] ------------[ cut here ]------------
> > [ 8.095469] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:3537 check_flags+0x77/0x1ba()
> > [ 8.095469] DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled)
>
> The warning is caused by the added raw_local_irq_save(), which should
> have been local_irq_save(flags). Actually, it is a false positive.
>
> Andrew, considered that your approach may be more efficient than this
> one since preempt_disable()/preempt_enable() can be removed too.
>
> So could you prepare one patch for fixing the problem? Or if you are busy, I'd
> like to do it.
Yes, please send a fresh patch.
prev parent reply other threads:[~2014-01-11 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 16:14 [percpu_counter] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:3537 check_flags() kernel test robot
2014-01-11 16:36 ` Ming Lei
2014-01-11 20:48 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140111124841.00cd5893.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.