[Buildroot] [PATCH v2] ca-certificates: new package

[Yann E. MORIN <yann.morin.1998@free.fr>]

Martin, All,

On 2014-01-10 14:24 +0000, Martin Bark spake thusly:
> On 09/01/14 23:59, Yann E. MORIN wrote:
[--SNIP--]
> >>+    #generate symlinks to certificates under /etc/ssl/certs
> >>+    ( \
> >>+      cd $(TARGET_DIR) ;\
> >>+      for i in `find usr/share/ca-certificates -name "*.crt"` ; do \
> >>+            ln -sf ../../../$$i etc/ssl/certs/`basename $${i%.crt}.pem` ;\
> >>+      done ;\
> >>+    )
> >
> >As stated by Thomas, this is not very nice.
> >
> >However, you do not need to enclose the command in-between a ()-pair,
> >since make will spawn a shell for each 'command', and thus the cd is in
> >effect only in that shell. That is, the following line:
> >
> >>+    $(HOST_DIR)/usr/bin/c_rehash $(TARGET_DIR)/etc/ssl/certs
> >
> >Will be executed in another shell.
> >
> >Also, your use of basename is weird. I'd use this instead:
> >     `basename $${i} .crt`.pem
> 
> I was using the bash ${var%Pattern} substitution but your solution is
> neater.  I'll make those changes now.

Yes, I know about this, and I even use it a lot. But I think it is not
obvious enough in this context.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'