From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Sun, 12 Jan 2014 09:22:01 +0100 Subject: [PATCH v2 26/28] drm/i2c: tda998x: code optimization In-Reply-To: <20140111185509.GL15937@n2100.arm.linux.org.uk> References: <20140109120725.0b0f3e55@armhf> <20140111185509.GL15937@n2100.arm.linux.org.uk> Message-ID: <20140112092201.764fb09c@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 11 Jan 2014 18:55:09 +0000 Russell King - ARM Linux wrote: > On Thu, Jan 09, 2014 at 12:07:25PM +0100, Jean-Francois Moine wrote: > > This patch reduces the number of I2C exchanges by setting many bits in > > one write and removing a useless write. > > > > Signed-off-by: Jean-Francois Moine > > --- > > drivers/gpu/drm/i2c/tda998x_drv.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c > > index 6b4f6d2..d3b3f3a 100644 > > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c > > @@ -751,10 +751,10 @@ tda998x_configure_audio(struct tda998x_priv *priv, > > } > > > > reg_write(priv, REG_AIP_CLKSEL, clksel_aip); > > - reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_LAYOUT); > > + reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_LAYOUT | > > This patch clearly hasn't even been build tested, so I doubt there's > much point reviewing this or the following patches. From a quick scan > of the following patches, this never got fixed so the following patches > can't have been build tested either. I don't see what can be the problem with this patch. It does not change anything in the logic. About testing, it is applied to my Cubox kernel for more than 4 months and everything works correctly. I will move the following comment a bit upwards. Maybe the code will be clearer. -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v2 26/28] drm/i2c: tda998x: code optimization Date: Sun, 12 Jan 2014 09:22:01 +0100 Message-ID: <20140112092201.764fb09c@armhf> References: <20140109120725.0b0f3e55@armhf> <20140111185509.GL15937@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by gabe.freedesktop.org (Postfix) with ESMTP id 70A60FB563 for ; Sun, 12 Jan 2014 00:22:31 -0800 (PST) In-Reply-To: <20140111185509.GL15937@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAxMSBKYW4gMjAxNCAxODo1NTowOSArMDAwMApSdXNzZWxsIEtpbmcgLSBBUk0gTGlu dXggPGxpbnV4QGFybS5saW51eC5vcmcudWs+IHdyb3RlOgoKPiBPbiBUaHUsIEphbiAwOSwgMjAx NCBhdCAxMjowNzoyNVBNICswMTAwLCBKZWFuLUZyYW5jb2lzIE1vaW5lIHdyb3RlOgo+ID4gVGhp cyBwYXRjaCByZWR1Y2VzIHRoZSBudW1iZXIgb2YgSTJDIGV4Y2hhbmdlcyBieSBzZXR0aW5nIG1h bnkgYml0cyBpbgo+ID4gb25lIHdyaXRlIGFuZCByZW1vdmluZyBhIHVzZWxlc3Mgd3JpdGUuCj4g PiAKPiA+IFNpZ25lZC1vZmYtYnk6IEplYW4tRnJhbmNvaXMgTW9pbmUgPG1vaW5lamZAZnJlZS5m cj4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk4eF9kcnYuYyAgIHwgMTAg KysrKy0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDYgZGVsZXRp b25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5OHhf ZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5OHhfZHJ2LmMKPiA+IGluZGV4IDZiNGY2 ZDIuLmQzYjNmM2EgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5OHhf ZHJ2LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk4eF9kcnYuYwo+ID4gQEAg LTc1MSwxMCArNzUxLDEwIEBAIHRkYTk5OHhfY29uZmlndXJlX2F1ZGlvKHN0cnVjdCB0ZGE5OTh4 X3ByaXYgKnByaXYsCj4gPiAgCX0KPiA+ICAKPiA+ICAJcmVnX3dyaXRlKHByaXYsIFJFR19BSVBf Q0xLU0VMLCBjbGtzZWxfYWlwKTsKPiA+IC0JcmVnX2NsZWFyKHByaXYsIFJFR19BSVBfQ05UUkxf MCwgQUlQX0NOVFJMXzBfTEFZT1VUKTsKPiA+ICsJcmVnX2NsZWFyKHByaXYsIFJFR19BSVBfQ05U UkxfMCwgQUlQX0NOVFJMXzBfTEFZT1VUIHwKPiAKPiBUaGlzIHBhdGNoIGNsZWFybHkgaGFzbid0 IGV2ZW4gYmVlbiBidWlsZCB0ZXN0ZWQsIHNvIEkgZG91YnQgdGhlcmUncwo+IG11Y2ggcG9pbnQg cmV2aWV3aW5nIHRoaXMgb3IgdGhlIGZvbGxvd2luZyBwYXRjaGVzLiAgRnJvbSBhIHF1aWNrIHNj YW4KPiBvZiB0aGUgZm9sbG93aW5nIHBhdGNoZXMsIHRoaXMgbmV2ZXIgZ290IGZpeGVkIHNvIHRo ZSBmb2xsb3dpbmcgcGF0Y2hlcwo+IGNhbid0IGhhdmUgYmVlbiBidWlsZCB0ZXN0ZWQgZWl0aGVy LgoKSSBkb24ndCBzZWUgd2hhdCBjYW4gYmUgdGhlIHByb2JsZW0gd2l0aCB0aGlzIHBhdGNoLiBJ dCBkb2VzIG5vdCBjaGFuZ2UKYW55dGhpbmcgaW4gdGhlIGxvZ2ljLiBBYm91dCB0ZXN0aW5nLCBp dCBpcyBhcHBsaWVkIHRvIG15IEN1Ym94IGtlcm5lbApmb3IgbW9yZSB0aGFuIDQgbW9udGhzIGFu ZCBldmVyeXRoaW5nIHdvcmtzIGNvcnJlY3RseS4KCkkgd2lsbCBtb3ZlIHRoZSBmb2xsb3dpbmcg Y29tbWVudCBhIGJpdCB1cHdhcmRzLiBNYXliZSB0aGUgY29kZSB3aWxsIGJlCmNsZWFyZXIuCgot LSAKS2VuIGFyIGMnaGVudGHDsQl8CSAgICAgICoqIEJyZWl6aCBoYSBMaW51eCBhdGF2ISAqKgpK ZWYJCXwJCWh0dHA6Ly9tb2luZWpmLmZyZWUuZnIvCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751137AbaALIWi (ORCPT ); Sun, 12 Jan 2014 03:22:38 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:57661 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbaALIWg convert rfc822-to-8bit (ORCPT ); Sun, 12 Jan 2014 03:22:36 -0500 Date: Sun, 12 Jan 2014 09:22:01 +0100 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, Rob Clark , Dave Airlie , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 26/28] drm/i2c: tda998x: code optimization Message-ID: <20140112092201.764fb09c@armhf> In-Reply-To: <20140111185509.GL15937@n2100.arm.linux.org.uk> References: <20140109120725.0b0f3e55@armhf> <20140111185509.GL15937@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Jan 2014 18:55:09 +0000 Russell King - ARM Linux wrote: > On Thu, Jan 09, 2014 at 12:07:25PM +0100, Jean-Francois Moine wrote: > > This patch reduces the number of I2C exchanges by setting many bits in > > one write and removing a useless write. > > > > Signed-off-by: Jean-Francois Moine > > --- > > drivers/gpu/drm/i2c/tda998x_drv.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c > > index 6b4f6d2..d3b3f3a 100644 > > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c > > @@ -751,10 +751,10 @@ tda998x_configure_audio(struct tda998x_priv *priv, > > } > > > > reg_write(priv, REG_AIP_CLKSEL, clksel_aip); > > - reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_LAYOUT); > > + reg_clear(priv, REG_AIP_CNTRL_0, AIP_CNTRL_0_LAYOUT | > > This patch clearly hasn't even been build tested, so I doubt there's > much point reviewing this or the following patches. From a quick scan > of the following patches, this never got fixed so the following patches > can't have been build tested either. I don't see what can be the problem with this patch. It does not change anything in the logic. About testing, it is applied to my Cubox kernel for more than 4 months and everything works correctly. I will move the following comment a bit upwards. Maybe the code will be clearer. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/