From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Sun, 12 Jan 2014 13:23:21 +0100 Subject: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting In-Reply-To: <20140111183648.GH15937@n2100.arm.linux.org.uk> References: <20140109120607.6a33bee5@armhf> <20140111183648.GH15937@n2100.arm.linux.org.uk> Message-ID: <20140112132321.757f3fa7@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 11 Jan 2014 18:36:48 +0000 Russell King - ARM Linux wrote: > On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote: > > According to the comment, the TBG_CNTRL_0 register must be set at the > > end of the mode change sequence. > > So you believe comments without understanding the history, and you move > code around due to those. > > No, this is again wrong. That write to REG_TBG_CNTRL_0 in the sequence > writing the video information to the chip. This doesn't encompass the > HDMI/DVI mode setting nor the audio configuration - the audio configuration > can change independently of the video setting, and does not require this > register to be written. > > This also brings up a bug in one of your previous patches which I now > must go back and comment upon. Well, I have not the full spec of the TDA998x's, and I don't know what is important or not. I was hoping that Rob had a better knowledge than I. So, in my patch 9, I was writing the REG_TBG_CNTRL_1 after writing REG_TBG_CNTRL_0, and you refused it. Here, I write REG_TBG_CNTRL_0 after the write of REG_TBG_CNTRL_1 in the HDMI sequence, and you still don't agree. What is the right way? -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting Date: Sun, 12 Jan 2014 13:23:21 +0100 Message-ID: <20140112132321.757f3fa7@armhf> References: <20140109120607.6a33bee5@armhf> <20140111183648.GH15937@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [212.27.42.6]) by gabe.freedesktop.org (Postfix) with ESMTP id AD08FFB0C2 for ; Sun, 12 Jan 2014 04:23:54 -0800 (PST) In-Reply-To: <20140111183648.GH15937@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAxMSBKYW4gMjAxNCAxODozNjo0OCArMDAwMApSdXNzZWxsIEtpbmcgLSBBUk0gTGlu dXggPGxpbnV4QGFybS5saW51eC5vcmcudWs+IHdyb3RlOgoKPiBPbiBUaHUsIEphbiAwOSwgMjAx NCBhdCAxMjowNjowN1BNICswMTAwLCBKZWFuLUZyYW5jb2lzIE1vaW5lIHdyb3RlOgo+ID4gQWNj b3JkaW5nIHRvIHRoZSBjb21tZW50LCB0aGUgVEJHX0NOVFJMXzAgcmVnaXN0ZXIgbXVzdCBiZSBz ZXQgYXQgdGhlCj4gPiBlbmQgb2YgdGhlIG1vZGUgY2hhbmdlIHNlcXVlbmNlLgo+IAo+IFNvIHlv dSBiZWxpZXZlIGNvbW1lbnRzIHdpdGhvdXQgdW5kZXJzdGFuZGluZyB0aGUgaGlzdG9yeSwgYW5k IHlvdSBtb3ZlCj4gY29kZSBhcm91bmQgZHVlIHRvIHRob3NlLgo+IAo+IE5vLCB0aGlzIGlzIGFn YWluIHdyb25nLiAgVGhhdCB3cml0ZSB0byBSRUdfVEJHX0NOVFJMXzAgaW4gdGhlIHNlcXVlbmNl Cj4gd3JpdGluZyB0aGUgdmlkZW8gaW5mb3JtYXRpb24gdG8gdGhlIGNoaXAuICBUaGlzIGRvZXNu J3QgZW5jb21wYXNzIHRoZQo+IEhETUkvRFZJIG1vZGUgc2V0dGluZyBub3IgdGhlIGF1ZGlvIGNv bmZpZ3VyYXRpb24gLSB0aGUgYXVkaW8gY29uZmlndXJhdGlvbgo+IGNhbiBjaGFuZ2UgaW5kZXBl bmRlbnRseSBvZiB0aGUgdmlkZW8gc2V0dGluZywgYW5kIGRvZXMgbm90IHJlcXVpcmUgdGhpcwo+ IHJlZ2lzdGVyIHRvIGJlIHdyaXR0ZW4uCj4gCj4gVGhpcyBhbHNvIGJyaW5ncyB1cCBhIGJ1ZyBp biBvbmUgb2YgeW91ciBwcmV2aW91cyBwYXRjaGVzIHdoaWNoIEkgbm93Cj4gbXVzdCBnbyBiYWNr IGFuZCBjb21tZW50IHVwb24uCgpXZWxsLCBJIGhhdmUgbm90IHRoZSBmdWxsIHNwZWMgb2YgdGhl IFREQTk5OHgncywgYW5kIEkgZG9uJ3Qga25vdyB3aGF0CmlzIGltcG9ydGFudCBvciBub3QuIEkg d2FzIGhvcGluZyB0aGF0IFJvYiBoYWQgYSBiZXR0ZXIga25vd2xlZGdlIHRoYW4gSS4KClNvLCBp biBteSBwYXRjaCA5LCBJIHdhcyB3cml0aW5nIHRoZSBSRUdfVEJHX0NOVFJMXzEgYWZ0ZXIgd3Jp dGluZwpSRUdfVEJHX0NOVFJMXzAsIGFuZCB5b3UgcmVmdXNlZCBpdC4gSGVyZSwgSSB3cml0ZSBS RUdfVEJHX0NOVFJMXzAKYWZ0ZXIgdGhlIHdyaXRlIG9mIFJFR19UQkdfQ05UUkxfMSBpbiB0aGUg SERNSSBzZXF1ZW5jZSwgYW5kIHlvdSBzdGlsbApkb24ndCBhZ3JlZS4KCldoYXQgaXMgdGhlIHJp Z2h0IHdheT8KCi0tIApLZW4gYXIgYydoZW50YcOxCXwJICAgICAgKiogQnJlaXpoIGhhIExpbnV4 IGF0YXYhICoqCkplZgkJfAkJaHR0cDovL21vaW5lamYuZnJlZS5mci8KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbaALMYK (ORCPT ); Sun, 12 Jan 2014 07:24:10 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]:58924 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbaALMX5 convert rfc822-to-8bit (ORCPT ); Sun, 12 Jan 2014 07:23:57 -0500 Date: Sun, 12 Jan 2014 13:23:21 +0100 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, Rob Clark , Dave Airlie , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting Message-ID: <20140112132321.757f3fa7@armhf> In-Reply-To: <20140111183648.GH15937@n2100.arm.linux.org.uk> References: <20140109120607.6a33bee5@armhf> <20140111183648.GH15937@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Jan 2014 18:36:48 +0000 Russell King - ARM Linux wrote: > On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote: > > According to the comment, the TBG_CNTRL_0 register must be set at the > > end of the mode change sequence. > > So you believe comments without understanding the history, and you move > code around due to those. > > No, this is again wrong. That write to REG_TBG_CNTRL_0 in the sequence > writing the video information to the chip. This doesn't encompass the > HDMI/DVI mode setting nor the audio configuration - the audio configuration > can change independently of the video setting, and does not require this > register to be written. > > This also brings up a bug in one of your previous patches which I now > must go back and comment upon. Well, I have not the full spec of the TDA998x's, and I don't know what is important or not. I was hoping that Rob had a better knowledge than I. So, in my patch 9, I was writing the REG_TBG_CNTRL_1 after writing REG_TBG_CNTRL_0, and you refused it. Here, I write REG_TBG_CNTRL_0 after the write of REG_TBG_CNTRL_1 in the HDMI sequence, and you still don't agree. What is the right way? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/