From: Jean-Francois Moine <moinejf@free.fr>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH] ASoC: simple-card: remove snd_link and snd_card from struct asoc_xx_info
Date: Mon, 13 Jan 2014 08:56:48 +0100 [thread overview]
Message-ID: <20140113085648.0fbcf63b@armhf> (raw)
In-Reply-To: <1389358557-2214-1-git-send-email-Li.Xiubo@freescale.com>
On Fri, 10 Jan 2014 20:55:57 +0800
Xiubo Li <Li.Xiubo@freescale.com> wrote:
> Whether the dt is used or not, almost all the simple card information
> for the DAI link and sound card are initialized in the simple card driver.
>
> And for the platform caller, the snd_link and snd_card are of no use, so
> remove it from struct asoc_simple_card_info, and let them to be the simple
> card driver's global data.
>
> This is also fix one bug about writing to the platform data directly, for
> it should be constant.
>
> And now only one DAI link is supported for simple card.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
>
> This patch maybe not very perfect, such as supporting many DAI links, etc.
> And there still need followed patches to fulfil these.
[snip]
Xiubo,
I don't agree your code: you should not use the cinfo anymore, but
rather move the information it contains to the sound card structure.
Then, you use a static variable as the card structure. It is not
possible to extend this table to handle many DAI links, and, as not
re-entrant, the driver cannot create many sound cards.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-01-13 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 12:55 [PATCH] ASoC: simple-card: remove snd_link and snd_card from struct asoc_xx_info Xiubo Li
2014-01-13 7:56 ` Jean-Francois Moine [this message]
2014-01-13 10:28 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113085648.0fbcf63b@armhf \
--to=moinejf@free.fr \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.