From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: nftables: improve build system
Date: Mon, 13 Jan 2014 09:12:51 +0000 [thread overview]
Message-ID: <20140113091250.GB14601@macbook.localnet> (raw)
In-Reply-To: <1389604070-12068-1-git-send-email-jengelh@inai.de>
On Mon, Jan 13, 2014 at 10:07:47AM +0100, Jan Engelhardt wrote:
>
> The following changes since commit b566123b9b60aff8ef21dfa7b21f817261236b1d:
>
> nftables: drop hard coded install using root user owner and group (2014-01-13 06:36:45 +0000)
>
> are available in the git repository at:
>
> git://git.inai.de/nftables master
>
> for you to fetch changes up to 54f180f8d762259d6fe5f671e5b19cf9a5a9b683:
>
> build: use automake and pkgconfig (2014-01-13 10:04:35 +0100)
I have no general objections against moving to automake/pkgconfig, but
your changelogs leave room for improvement.
> build: remove unused checks
Why aren't we instead evaluating the results?
> build: rename conflicting parser.h instances
The changelog mentions something about -I but no further explanation about
why this change is done and the effects.
I can't really comment on these changes unless I have further explanation.
next prev parent reply other threads:[~2014-01-13 9:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 9:07 nftables: improve build system Jan Engelhardt
2014-01-13 9:07 ` [PATCH 1/3] build: remove unused checks Jan Engelhardt
2014-01-13 9:07 ` [PATCH 2/3] build: rename conflicting parser.h instances Jan Engelhardt
2014-01-13 9:07 ` [PATCH 3/3] build: use automake and pkgconfig Jan Engelhardt
2014-01-13 9:12 ` Patrick McHardy [this message]
2014-01-13 9:47 ` nftables: improve build system Jan Engelhardt
2014-01-13 9:56 ` Patrick McHardy
2014-01-13 10:56 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113091250.GB14601@macbook.localnet \
--to=kaber@trash.net \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.