From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] libxl: disallow PCI device assignment for
 HVM guest when PoD is enabled
Date: Mon, 13 Jan 2014 11:45:35 +0000
Message-ID: <20140113114535.GE5698@zion.uk.xensource.com>
References: <1389353262-27668-1-git-send-email-wei.liu2@citrix.com>
	<20140113105413.GB5698@zion.uk.xensource.com>
	<1389611480.13654.33.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1389611480.13654.33.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Xiantao Zhang <xiantao.zhang@intel.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, Jan 13, 2014 at 11:11:20AM +0000, Ian Campbell wrote:
> On Mon, 2014-01-13 at 10:54 +0000, Wei Liu wrote:
> > Any more comments on code logic and / or the location of the new
> > snippet? Should I send a new version with code comment fixed?
> > [...] 
> > > +    /* If target_memkb is smaller than max_memkb, the subsequent call
> > > +     * to libxc when building HVM domain will enable PoD mode.
> > > +     */
> > > +    pod_enabled = (d_config->c_info.type == LIBXL_DOMAIN_TYPE_HVM) &&
> > > +        (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
> 
> I suppose this corresponds to exactly when PoD would be enabled?
> 

Yes. In libxc if maxmem > target_mem then pod_mode is set. See
tools/libxc/xc_hvm_build_x86.c:setup_guest.

> I'm happy with the patch, and it would be better to go ahead now than to
> wait for George (with his PoD hat in place) to confirm/deny, so please
> resend with the improved comment.

Will do.

Wei.

> 
> Ian.
>