From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 1/6] efi: create memory map iteration helper Date: Mon, 13 Jan 2014 15:17:59 +0000 Message-ID: <20140113151759.GG3256@console-pimps.org> References: <1389392950-22457-1-git-send-email-msalter@redhat.com> <1389392950-22457-2-git-send-email-msalter@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1389392950-22457-2-git-send-email-msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Salter Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Catalin Marinas , Will Deacon , matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Leif Lindholm , roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Grant Likely List-Id: linux-efi@vger.kernel.org On Fri, 10 Jan, at 05:29:05PM, Mark Salter wrote: > There are a lot of places in the kernel which iterate through an > EFI memory map. Most of these places use essentially the same > for-loop code. This patch adds a for_each_efi_memory_desc() > helper to clean up all of the existing duplicate code and avoid > more in the future. > > Signed-off-by: Mark Salter > --- > include/linux/efi.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/efi.h b/include/linux/efi.h > index 11ce678..9dc5b05 100644 > --- a/include/linux/efi.h > +++ b/include/linux/efi.h > @@ -618,6 +618,12 @@ extern int efi_set_rtc_mmss(const struct timespec *now); > extern void efi_reserve_boot_services(void); > extern struct efi_memory_map memmap; > > +/* Iterate through an efi_memory_map */ > +#define for_each_efi_memory_desc(m, md) \ > + for ((md) = (m)->map; \ > + (md) <= (efi_memory_desc_t *)((m)->map_end - (m)->desc_size); \ > + (md) = (void *)(md) + (m)->desc_size) > + Err, what? I just picked up your previous patch ("x86/efi: Create memory map iteration helper") which adds this chunk, and I didn't see a follow up email telling me not to pick it up. What's the plan? -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: matt@console-pimps.org (Matt Fleming) Date: Mon, 13 Jan 2014 15:17:59 +0000 Subject: [PATCH 1/6] efi: create memory map iteration helper In-Reply-To: <1389392950-22457-2-git-send-email-msalter@redhat.com> References: <1389392950-22457-1-git-send-email-msalter@redhat.com> <1389392950-22457-2-git-send-email-msalter@redhat.com> Message-ID: <20140113151759.GG3256@console-pimps.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 10 Jan, at 05:29:05PM, Mark Salter wrote: > There are a lot of places in the kernel which iterate through an > EFI memory map. Most of these places use essentially the same > for-loop code. This patch adds a for_each_efi_memory_desc() > helper to clean up all of the existing duplicate code and avoid > more in the future. > > Signed-off-by: Mark Salter > --- > include/linux/efi.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/efi.h b/include/linux/efi.h > index 11ce678..9dc5b05 100644 > --- a/include/linux/efi.h > +++ b/include/linux/efi.h > @@ -618,6 +618,12 @@ extern int efi_set_rtc_mmss(const struct timespec *now); > extern void efi_reserve_boot_services(void); > extern struct efi_memory_map memmap; > > +/* Iterate through an efi_memory_map */ > +#define for_each_efi_memory_desc(m, md) \ > + for ((md) = (m)->map; \ > + (md) <= (efi_memory_desc_t *)((m)->map_end - (m)->desc_size); \ > + (md) = (void *)(md) + (m)->desc_size) > + Err, what? I just picked up your previous patch ("x86/efi: Create memory map iteration helper") which adds this chunk, and I didn't see a follow up email telling me not to pick it up. What's the plan? -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751696AbaAMPSH (ORCPT ); Mon, 13 Jan 2014 10:18:07 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:60281 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbaAMPSF (ORCPT ); Mon, 13 Jan 2014 10:18:05 -0500 Date: Mon, 13 Jan 2014 15:17:59 +0000 From: Matt Fleming To: Mark Salter Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, Catalin Marinas , Will Deacon , matt.fleming@intel.com, Leif Lindholm , roy.franz@linaro.org, patches@linaro.org, Grant Likely Subject: Re: [PATCH 1/6] efi: create memory map iteration helper Message-ID: <20140113151759.GG3256@console-pimps.org> References: <1389392950-22457-1-git-send-email-msalter@redhat.com> <1389392950-22457-2-git-send-email-msalter@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1389392950-22457-2-git-send-email-msalter@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Jan, at 05:29:05PM, Mark Salter wrote: > There are a lot of places in the kernel which iterate through an > EFI memory map. Most of these places use essentially the same > for-loop code. This patch adds a for_each_efi_memory_desc() > helper to clean up all of the existing duplicate code and avoid > more in the future. > > Signed-off-by: Mark Salter > --- > include/linux/efi.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/efi.h b/include/linux/efi.h > index 11ce678..9dc5b05 100644 > --- a/include/linux/efi.h > +++ b/include/linux/efi.h > @@ -618,6 +618,12 @@ extern int efi_set_rtc_mmss(const struct timespec *now); > extern void efi_reserve_boot_services(void); > extern struct efi_memory_map memmap; > > +/* Iterate through an efi_memory_map */ > +#define for_each_efi_memory_desc(m, md) \ > + for ((md) = (m)->map; \ > + (md) <= (efi_memory_desc_t *)((m)->map_end - (m)->desc_size); \ > + (md) = (void *)(md) + (m)->desc_size) > + Err, what? I just picked up your previous patch ("x86/efi: Create memory map iteration helper") which adds this chunk, and I didn't see a follow up email telling me not to pick it up. What's the plan? -- Matt Fleming, Intel Open Source Technology Center