From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Mon, 13 Jan 2014 16:37:35 +0100 Subject: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3 In-Reply-To: <20140111182602.GF15937@n2100.arm.linux.org.uk> References: <20140109120513.0965ddad@armhf> <20140111182602.GF15937@n2100.arm.linux.org.uk> Message-ID: <20140113163735.43c1d19b@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 11 Jan 2014 18:26:02 +0000 Russell King - ARM Linux wrote: > > div = 148500 / mode->clock; > > + if (div != 0) { > > + div--; > > + if (div > 3) > > + div = 3; > > + } > > As the driver currently stands, we know that the clock divider works for > the lower resolution modes. So, as things stand, for 74.25MHz modes, > we get a divisor of one. > > Your patch changes this, the divider becomes zero. I wonder whether > you've tested 720p modes at all with this? In 720p, the divider becomes (148500 / 74250 - 1) = 1 and this mode works fine. -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3 Date: Mon, 13 Jan 2014 16:37:35 +0100 Message-ID: <20140113163735.43c1d19b@armhf> References: <20140109120513.0965ddad@armhf> <20140111182602.GF15937@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [212.27.42.6]) by gabe.freedesktop.org (Postfix) with ESMTP id 719501101B4 for ; Mon, 13 Jan 2014 07:38:07 -0800 (PST) In-Reply-To: <20140111182602.GF15937@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAxMSBKYW4gMjAxNCAxODoyNjowMiArMDAwMApSdXNzZWxsIEtpbmcgLSBBUk0gTGlu dXggPGxpbnV4QGFybS5saW51eC5vcmcudWs+IHdyb3RlOgoKPiA+ICAJZGl2ID0gMTQ4NTAwIC8g bW9kZS0+Y2xvY2s7Cj4gPiArCWlmIChkaXYgIT0gMCkgewo+ID4gKwkJZGl2LS07Cj4gPiArCQlp ZiAoZGl2ID4gMykKPiA+ICsJCQlkaXYgPSAzOwo+ID4gKwl9ICAKPiAKPiBBcyB0aGUgZHJpdmVy IGN1cnJlbnRseSBzdGFuZHMsIHdlIGtub3cgdGhhdCB0aGUgY2xvY2sgZGl2aWRlciB3b3JrcyBm b3IKPiB0aGUgbG93ZXIgcmVzb2x1dGlvbiBtb2Rlcy4gIFNvLCBhcyB0aGluZ3Mgc3RhbmQsIGZv ciA3NC4yNU1IeiBtb2RlcywKPiB3ZSBnZXQgYSBkaXZpc29yIG9mIG9uZS4KPiAKPiBZb3VyIHBh dGNoIGNoYW5nZXMgdGhpcywgdGhlIGRpdmlkZXIgYmVjb21lcyB6ZXJvLiAgSSB3b25kZXIgd2hl dGhlcgo+IHlvdSd2ZSB0ZXN0ZWQgNzIwcCBtb2RlcyBhdCBhbGwgd2l0aCB0aGlzPwoKSW4gNzIw cCwgdGhlIGRpdmlkZXIgYmVjb21lcyAoMTQ4NTAwIC8gNzQyNTAgLSAxKSA9IDEgYW5kIHRoaXMg bW9kZQp3b3JrcyBmaW5lLgoKLS0gCktlbiBhciBjJ2hlbnRhw7EJfAkgICAgICAqKiBCcmVpemgg aGEgTGludXggYXRhdiEgKioKSmVmCQl8CQlodHRwOi8vbW9pbmVqZi5mcmVlLmZyLwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbaAMPiM (ORCPT ); Mon, 13 Jan 2014 10:38:12 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]:60444 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbaAMPiL convert rfc822-to-8bit (ORCPT ); Mon, 13 Jan 2014 10:38:11 -0500 Date: Mon, 13 Jan 2014 16:37:35 +0100 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, Rob Clark , Dave Airlie , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3 Message-ID: <20140113163735.43c1d19b@armhf> In-Reply-To: <20140111182602.GF15937@n2100.arm.linux.org.uk> References: <20140109120513.0965ddad@armhf> <20140111182602.GF15937@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Jan 2014 18:26:02 +0000 Russell King - ARM Linux wrote: > > div = 148500 / mode->clock; > > + if (div != 0) { > > + div--; > > + if (div > 3) > > + div = 3; > > + } > > As the driver currently stands, we know that the clock divider works for > the lower resolution modes. So, as things stand, for 74.25MHz modes, > we get a divisor of one. > > Your patch changes this, the divider becomes zero. I wonder whether > you've tested 720p modes at all with this? In 720p, the divider becomes (148500 / 74250 - 1) = 1 and this mode works fine. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/