From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH can-utils v2 1/3] headers: use include/linux only for Linux kernel headers Date: Mon, 13 Jan 2014 22:26:58 +0100 Message-ID: <20140113212658.GL29475@pengutronix.de> References: <1389481823-8379-1-git-send-email-u.kleine-koenig@pengutronix.de> <1389561879-16729-1-git-send-email-u.kleine-koenig@pengutronix.de> <1389561879-16729-2-git-send-email-u.kleine-koenig@pengutronix.de> <52D3867B.6090108@hartkopp.net> <20140113072049.GB29475@pengutronix.de> <52D42F90.7080005@hartkopp.net> <20140113204531.GI29475@pengutronix.de> <52D4580C.5030602@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:46364 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751578AbaAMV1A (ORCPT ); Mon, 13 Jan 2014 16:27:00 -0500 Content-Disposition: inline In-Reply-To: <52D4580C.5030602@hartkopp.net> Sender: linux-can-owner@vger.kernel.org List-ID: To: Oliver Hartkopp Cc: linux-can@vger.kernel.org, Marc Kleine-Budde , Yegor Yefremov Hello Oliver, On Mon, Jan 13, 2014 at 10:18:04PM +0100, Oliver Hartkopp wrote: > On 13.01.2014 21:45, Uwe Kleine-K=C3=B6nig wrote: > > On Mon, Jan 13, 2014 at 07:25:20PM +0100, Oliver Hartkopp wrote: > >> On 13.01.2014 08:20, Uwe Kleine-K=C3=B6nig wrote: > >>> On Mon, Jan 13, 2014 at 07:23:55AM +0100, Oliver Hartkopp wrote: > >>>> And e.g. this > >>>> > >>>>> #include > >>>>> -#include > >>>>> +#include "isotp.h" > >>>>> #include > >>>> > >>>> should be avoided too. > >>> Why? > >> > >> When isotp hits the kernel, there's no need to adapt all userland = programs. To be honest, it's not that hard to update all userland programs. I did it with: perl -p -i -e 's,^#include $,#include "isotp.h",= ' isotp* (well, plus some reformatting, but meh). > > ah, didn't know that isotp targets the kernel. There is nothing in = next > > yet. I wonder if it's sensible to put it into can-utils' copy of th= e > > kernel headers then. If you ask me keep isotp.h in / until it hits = the > > kernel, then sync the headers and switch the programs explicitly. O= nly > > my 0.02 =E2=82=AC. >=20 > What's the benefit of moving it to root and then moving it back to th= e includes? The benefit is that there is less chance for surprises. Updating the kernel header copy still has a manual component when there are files in can-utils that are not existing in the kernel. Also I like changes to b= e explicit. When isotp.h is now kept in can-utils/include/linux and later hits the kernel there is no explicit commit that marks the start of using the kernel header and changing the procedure how to sync kernel headers. YMMV > Please let it stay in the current place. To late for v3, only read your mail when I sent it out. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=C3=B6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |