From: Greg KH <gregkh@linuxfoundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, stern@rowland.harvard.edu,
JBottomley@parallels.com, bhelgaas@google.com
Subject: Re: [PATCHSET v3 driver-core-next] kernfs, sysfs, driver-core: implement synchronous self-removal
Date: Mon, 13 Jan 2014 14:50:34 -0800 [thread overview]
Message-ID: <20140113225034.GA4031@kroah.com> (raw)
In-Reply-To: <20140113211715.GB3480@mtj.dyndns.org>
On Mon, Jan 13, 2014 at 04:17:15PM -0500, Tejun Heo wrote:
> On Sat, Jan 11, 2014 at 01:45:13PM -0500, Tejun Heo wrote:
> > Hey, Greg.
> >
> > On Fri, Jan 10, 2014 at 04:19:53PM -0800, Greg KH wrote:
> > > > It's really late in the -rc cycle for me to take this for 3.14, but I
> > > > see patch 1 is a good one to have, so I'll take that now, and queue the
> > > > rest up for after 3.14-rc1 is out for 3.15. Is that ok with you, or do
> > > > you have patches that depend on this series for 3.14?
> > >
> > > Oh nevermind, these are all good, now applied :)
> >
> > I don't have anything depending on the series for the up coming merge
> > window so 3.15 merge window would have been fine but 3.14 merge
> > windows wokrs too. :)
>
> Greg, I'm sorry but can you please revert the whole series?
> get_active() waiting while a node is deactivated has potential to lead
> to deadlock and that deactivate/reactivate interface is something
> fundamentally flawed and that cgroup will have to work with the
> remove_self() like everybody else. IOW, I think the first posting was
> correct.
>
> I think we better defer this to the next window and I'll do the whole
> thing - kernfs updates & cgroup conversion - together and then push
> out patches so that I don't repeat these mistakes.
>
> Sorry about the mess. I got tunnel-visioned thinking about cgroup
> semantics too much.
No worries, but it is sad, I really liked seeing that odd "remove self"
function go away. I've now reverted all 15 patches, please verify that
I didn't mess anything up in my tree somehow.
thanks,
greg k-h
next prev parent reply other threads:[~2014-01-13 22:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 13:57 [PATCHSET v3 driver-core-next] kernfs, sysfs, driver-core: implement synchronous self-removal Tejun Heo
2014-01-10 13:57 ` [PATCH 01/14] kernfs: fix get_active failure handling in kernfs_seq_*() Tejun Heo
2014-01-10 13:57 ` [PATCH 02/14] kernfs: replace kernfs_node->u.completion with kernfs_root->deactivate_waitq Tejun Heo
2014-01-10 13:57 ` [PATCH 03/14] kernfs: remove KERNFS_ACTIVE_REF and add kernfs_lockdep() Tejun Heo
2014-01-10 13:57 ` [PATCH 04/14] kernfs: remove KERNFS_REMOVED Tejun Heo
2014-01-10 13:57 ` [PATCH 05/14] kernfs: restructure removal path to fix possible premature return Tejun Heo
2014-01-10 13:57 ` [PATCH 06/14] kernfs: invoke kernfs_unmap_bin_file() directly from __kernfs_remove() Tejun Heo
2014-01-10 13:57 ` [PATCH 07/14] kernfs: remove kernfs_addrm_cxt Tejun Heo
2014-01-10 13:57 ` [PATCH 08/14] kernfs: make kernfs_get_active() block if the node is deactivated but not removed Tejun Heo
2014-01-10 13:57 ` [PATCH 09/14] kernfs: implement kernfs_{de|re}activate[_self]() Tejun Heo
2014-01-10 13:57 ` [PATCH 10/14] kernfs, sysfs, driver-core: implement kernfs_remove_self() and its wrappers Tejun Heo
2014-01-10 13:57 ` [PATCH 11/14] pci: use device_remove_file_self() instead of device_schedule_callback() Tejun Heo
2014-01-10 13:57 ` [PATCH 12/14] scsi: " Tejun Heo
2014-01-10 13:57 ` [PATCH 13/14] s390: " Tejun Heo
2014-01-10 13:57 ` [PATCH 14/14] sysfs, driver-core: remove unused {sysfs|device}_schedule_callback_owner() Tejun Heo
2014-01-10 15:08 ` [PATCHSET v3 driver-core-next] kernfs, sysfs, driver-core: implement synchronous self-removal Greg KH
2014-01-11 0:19 ` Greg KH
2014-01-11 18:45 ` Tejun Heo
2014-01-13 21:17 ` Tejun Heo
2014-01-13 22:50 ` Greg KH [this message]
2014-01-13 22:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113225034.GA4031@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=JBottomley@parallels.com \
--cc=bhelgaas@google.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.