From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: [PATCH v2 7/7] dm snapshot: use bufio prefetch
Date: Mon, 13 Jan 2014 17:56:52 -0500 [thread overview]
Message-ID: <20140113225651.GA1678@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1401131659250.12957@file01.intranet.prod.int.rdu2.redhat.com>
On Mon, Jan 13 2014 at 5:00pm -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:
> No.
>
> This changed patch inefficiently loops in bufio_prefetch_chunks for each
> buffer that is read.
Yeah, I overlooked the importance of preserving prefetch_area (which
explains the unlikely you had). But my intent was to make your code
less "special"; your if (DM_PREFETCH_CHUNKS) do { } while() code to
avoid the extra indentation is pretty ugly.
Given your current code, DM_PREFETCH_CHUNKS is always 12 so why not just
remove the check?
next prev parent reply other threads:[~2014-01-13 22:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 17:28 [PATCH 0/7] dm-snapshot prefetch patches Mikulas Patocka
2014-01-11 17:29 ` [PATCH 1/7] dm-bufio: return success or failure on prefetch Mikulas Patocka
2014-01-11 17:29 ` [PATCH 2/7] dm-bufio: introduce dm_bufio_forget Mikulas Patocka
2014-01-11 17:30 ` [PATCH 3/7] dm-bufio: introduce dm_bufio_set_minimum_buffers Mikulas Patocka
2014-01-11 17:30 ` [PATCH 4/7] dm-snapshot: use GFP_KERNEL when initializing the snapshot Mikulas Patocka
2014-01-11 17:30 ` [PATCH 5/7] dm-snapshot: make ps->area explicit Mikulas Patocka
2014-01-11 17:31 ` [PATCH 6/7] dm-snapshot: use dm-bufio Mikulas Patocka
2014-01-11 17:32 ` [PATCH 7/7] dm-snapshot: use bufio prefetch Mikulas Patocka
2014-01-13 21:27 ` Mike Snitzer
2014-01-13 22:03 ` Mikulas Patocka
2014-01-13 21:37 ` [PATCH v2 7/7] dm snapshot: " Mike Snitzer
2014-01-13 22:00 ` Mikulas Patocka
2014-01-13 22:56 ` Mike Snitzer [this message]
2014-01-13 23:45 ` Mikulas Patocka
2014-01-13 23:59 ` Mike Snitzer
2014-01-14 0:11 ` Mikulas Patocka
2014-01-13 21:21 ` [PATCH 1/7] dm-bufio: return success or failure on prefetch Mike Snitzer
2014-01-14 0:11 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113225651.GA1678@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.