Re: [PATCH 6/6] staging: vt6656: sparse fixes: aes_ccmp.c missing header.

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Jan 13, 2014 at 04:29:15PM +0000, Malcolm Priestley wrote:
> Add missing aes_ccmp.h header and move device.h to
> aes_ccmp.h

Why move device.h?

That shouldn't be needed to fix this issue.

> sparse warning
> aes_ccmp.c:221:6: warning: symbol 'AESbGenCCMP' was not declared. Should it be static?
> 
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
>  drivers/staging/vt6656/aes_ccmp.c | 2 +-
>  drivers/staging/vt6656/aes_ccmp.h | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/aes_ccmp.c b/drivers/staging/vt6656/aes_ccmp.c
> index 61b9f7b..3dbf458 100644
> --- a/drivers/staging/vt6656/aes_ccmp.c
> +++ b/drivers/staging/vt6656/aes_ccmp.c
> @@ -30,7 +30,7 @@
>   * Revision History:
>   */
>  
> -#include "device.h"
> +#include "aes_ccmp.h"
>  #include "80211hdr.h"
>  
>  /*
> diff --git a/drivers/staging/vt6656/aes_ccmp.h b/drivers/staging/vt6656/aes_ccmp.h
> index ed6a9ae..4cac3ec 100644
> --- a/drivers/staging/vt6656/aes_ccmp.h
> +++ b/drivers/staging/vt6656/aes_ccmp.h
> @@ -30,6 +30,8 @@
>  #ifndef __AES_H__
>  #define __AES_H__
>  
> +#include "device.h"

If you can prevent it, keeping .h files from having to include other .h
files is a good thing.

thanks,

greg k-h