All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Kirillov <max@max630.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Benoît Bourbié" <benoit.bourbie@gmail.com>,
	git@vger.kernel.org, "Max Kirillov" <max@max630.net>,
	"Pat Thoyts" <patthoyts@users.sourceforge.net>
Subject: Re: git gui crashes ( v 1.8.5.2)
Date: Tue, 14 Jan 2014 08:50:14 +0200	[thread overview]
Message-ID: <20140114065014.GA29816@wheezy.local> (raw)
In-Reply-To: <20140114011141.GF18964@google.com>

Hi.

On Mon, Jan 13, 2014 at 05:11:41PM -0800, Jonathan Nieder wrote:
> (just cc-ing some area experts)
> Benoît Bourbié wrote:
>> git gui crashes on my Linux machin since I updated it to 1.8.5.2.

I believe this happens at tk8.4 or earlier. I have not
tested it there, and according to the manpages in Internet
the older versions do not have the -stretch option.

Before I can find a system to test it, I think the panned
right half should really be reverted for the older versions of
tk. I remember it did not behave correctly without the
stretch option.

Maybe, to avoid cluttering the code, panedwindow should nit
be used at all without the ttk.

I'll try to submit a fix today.

-- 
Max

  parent reply	other threads:[~2014-01-14  6:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14  0:14 git gui crashes ( v 1.8.5.2) Benoît Bourbié
2014-01-14  1:11 ` Jonathan Nieder
2014-01-14  4:06   ` Benoît Bourbié
2014-01-14  6:50   ` Max Kirillov [this message]
2014-01-14 23:58     ` [PATCH] git-gui: fallback right pane to packed widgets with Tk 8.4 Max Kirillov
2014-01-16 16:39       ` Benoît Bourbié

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140114065014.GA29816@wheezy.local \
    --to=max@max630.net \
    --cc=benoit.bourbie@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=patthoyts@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.