Re: mlx4_core probe error after applying Yinghai's patch

[Wei Yang <weiyang@linux.vnet.ibm.com>]

On Tue, Jan 14, 2014 at 09:55:09AM +0200, Or Gerlitz wrote:
>On 14/01/2014 08:22, Wei Yang wrote:
>>All,
>>
>>I am testing Yinghai's patch based on 3.13-rc1, after applying these four
>>patches, there is an error during probe for mlx4_core.
>>
>>Code base we did the test:
>>   $ git oneline -5
>>   298a335 PCI: Try best to allocate pref mmio 64bit above 4g
>>   b730e81 PCI: Try to allocate mem64 above 4G at first
>>   4e27325 PCI: Don't use 4G bus address directly in resource allocation
>>   ab6c20f PCI: pcibus address to resource converting take bus instead of dev
>>   6ce4eac Linux 3.13-rc1
>>Error log:
>>   mlx4_core 0003:05:00.0: Multiple PFs not yet supported.  Skipping PF.
>>   mlx4_core: probe of 0003:05:00.0 failed with error -22
>>
>>My analysis:
>>   After careful investigation, I guess this error is not introduced by
>>   Yinghai's patch. This looks more like an error from device itself. Since
>>   this error really happens after applying Yinghai's patch(especially the last
>>   one 298a335), I would like to include Yinghai in this loop.
>
>Sorry, can you provide pointers please? I don't see 298a335 on Linus
>3.13-rc8+ tree nor in net-next,
>
>$ git log --oneline --author=Yinghai v3.12..
>e7cc5cf PCI: Remove duplicate pci_disable_device() from
>pcie_portdrv_remove()
>cf3e1fe PCI: Workaround missing pci_set_master in pci drivers
>bee7f9c ACPI / x86: Increase override tables number limit
>6979287 x86/mm: Add 'step_size' comments to init_mem_mapping()
>

Or

Thanks for your reply. The SHA index in only on my system, since as I know the
last patch is not in upstream yet.

You can find the first three patches here:
https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/ pci/resource

And the last one is here:
https://lkml.org/lkml/2013/12/19/701

BTW, this card is flushed with FW built in IBM.

Yinghai,

If these are not the latest one, please let us know.

And 

>So  are you referring to patches on the PCI development tree
>git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git "next"
>branch? which
>
>Or.

-- 
Richard Yang
Help you, Help me